Skip to content

feat(l2): standardize Witness Execution Result #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

fedacking
Copy link
Contributor

@fedacking fedacking commented Jun 30, 2025

Motivation

We want to adapt execution witness result with other implementations, so we're changing the signature.

Description

  • Changed the execution witness result to use the fields state for the entire state and storage trie and the keys field.
  • Removed the chain_config field from execution witness, ethrex replay reinserts it when needed.
  • Renamed RPCHandler struct ExecutionWitness to ExecutionWitnessHandler (more clarity)
  • Changed Chainconfig to use by default the admin_NodeInfo endpoint if no network was provided
  • Changed the default networks to actually include the network if known

Copy link

github-actions bot commented Jun 30, 2025

Lines of code report

Total lines added: 156
Total lines removed: 24
Total lines changed: 180

Detailed view
+---------------------------------------------------------+-------+------+
| File                                                    | Lines | Diff |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/cache.rs                   | 50    | +6   |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/cli.rs                     | 408   | +6   |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/constants.rs               | 48    | -6   |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/fetcher.rs                 | 81    | -10  |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/main.rs                    | 21    | +1   |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/networks.rs                | 47    | +47  |
+---------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex_replay/src/run.rs                     | 96    | +8   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs                  | 764   | -7   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/common/types/block_execution_witness.rs   | 455   | +34  |
+---------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/prover.rs                   | 127   | +1   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/src/execution.rs | 358   | +9   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/src/io.rs        | 85    | +2   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/proof_coordinator.rs         | 539   | +5   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/l2/tee/quote-gen/src/sender.rs            | 81    | +1   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/admin/mod.rs               | 52    | -1   |
+---------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/clients/eth/errors.rs      | 275   | +11  |
+---------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/clients/eth/mod.rs         | 1297  | +25  |
+---------------------------------------------------------+-------+------+

@fedacking fedacking self-assigned this Jul 2, 2025
@fedacking fedacking added L2 Rollup client simplification Any refactor that makes code simpler and more straight forward labels Jul 2, 2025
@fedacking fedacking moved this to In Progress in ethrex_l2 Jul 2, 2025
@fedacking fedacking changed the title feat(l2): Standarize witness Execution Result feat(l2): standarize Witness Execution Result Jul 2, 2025
@fedacking fedacking marked this pull request as draft July 11, 2025 17:56
@tomip01 tomip01 moved this from In Review to In Progress in ethrex_l2 Jul 18, 2025
@fedacking fedacking moved this from In Progress to In Review in ethrex_l2 Jul 22, 2025
@fedacking fedacking marked this pull request as ready for review July 22, 2025 21:30
@fedacking fedacking marked this pull request as draft July 22, 2025 21:30
@fedacking fedacking moved this from In Review to In Progress in ethrex_l2 Jul 22, 2025
@fedacking fedacking marked this pull request as ready for review July 22, 2025 21:49
@fedacking fedacking moved this from In Progress to In Review in ethrex_l2 Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 Rollup client simplification Any refactor that makes code simpler and more straight forward
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants