fix(l1): fix hive daily workflow #3804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
reviewed
Jul 24, 2025
| @@ -85,7 +87,7 @@ jobs: | |||
| fi | |||
|
|
|||
| - name: Run Hive Simulation | |||
| run: cd hive && ./hive --client-file ../fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.test.simulation }} --sim.parallelism 16 ${{ env.HIVE_FLAGS }} --sim.loglevel 1 | |||
| run: cd hive && ./hive --client-file ../fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.test.simulation }} --sim.buildarg branch=${{ env.ETHEREUM_EXECUTION_SPEC_TEST_VERSION }} --sim.parallelism 16 ${{ env.HIVE_FLAGS }} --sim.loglevel 1 --docker.nocache "ethereum/eest/*" | |||
There was a problem hiding this comment.
why is --docker.nocache "ethereum/eest/*" needed?
There was a problem hiding this comment.
The eest tests were failing to read from cache the fixtures (Dockerfile) and the docker image for those simulators couldn't be built
This flag avoids that read, the image was built and the test finished running
mpaulucci
reviewed
Jul 25, 2025
| @@ -85,7 +87,7 @@ jobs: | |||
| fi | |||
|
|
|||
| - name: Run Hive Simulation | |||
| run: cd hive && ./hive --client-file ../fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.test.simulation }} --sim.parallelism 16 ${{ env.HIVE_FLAGS }} --sim.loglevel 1 | |||
| run: cd hive && ./hive --client-file ../fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.test.simulation }} --sim.buildarg branch=${{ env.ETHEREUM_EXECUTION_SPEC_TEST_VERSION }} --sim.parallelism 16 ${{ env.HIVE_FLAGS }} --sim.loglevel 1 --docker.nocache "ethereum/eest/*" | |||
There was a problem hiding this comment.
This seems to overwrite @JereSalo HIVE_FLAGS
|
Closing in favor of #3833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some weeks ago the hive daily report stopped running
Description
The problem was that the Ethereum Execution Spec Test Repo wasn't pinned in the workflow, now it's pinned to the release v4.5.0. Also the
docker.nocacheflag was set for theeesttests, without this flag there was a problem with the fixtures needed for the testsWith this changes the daily report work, but there amount of test that are being ran in the
Consume Engine testhas increase and there are failing tests, some test that used to work are no longer working. LinkCloses #3674