Skip to content

temp(l1,l2): all trie optimizations #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 74 commits into
base: main
Choose a base branch
from
Draft

temp(l1,l2): all trie optimizations #4923

wants to merge 74 commits into from

Conversation

@xqft
Copy link
Contributor

@xqft xqft commented Oct 17, 2025

Motivation

merged the 3 trie opts, temporary pr

xqft added 30 commits September 24, 2025 19:15
@xqft
opt
7f5a38b
@xqft
clean
4143094
@xqft
prealloc
a503cdb
@xqft
fast rlp encoding for branch
cc65ec9
@xqft
write directly to hasher
0d87f5b
@xqft
dont use encode_write
2475090
@xqft
precalc len, assume no inline
9731165
@xqft
precalc len and write to hasher
bf46e33
@xqft
quick rlp and hashing for the rest of nodes
9433e3c
@xqft
fix partial/prefix encoding
7132ea0
@xqft
Rename with_hash to with_hash_unchecked with safety note
33d3c8b 
Renamed the method to with_hash_unchecked and updated the documentation to include safety warnings.
@xqft
Replace with_hash with with_hash_unchecked in trie.rs
7f513ea
@xqft
fix partial/prefix encoding for case len 1
71519ea
@xqft
use correct len on value encoding
04faadd
@xqft
fix extension hash prefix
f7195f2
@xqft
fix conditional on < 0x80
3cbe873
@xqft
fix value prefix match case
b99f697
@xqft
add todo and unreachable
0c3571c
@xqft
bad assumption of leaf with single byte value
451b340
@xqft
memoize hash
2f6f981
@xqft
fmt
46207b6
@xqft
use encode_raw for branch
dfa1d27
@xqft
remove write, add arrayvec buf
d8e77d9
@xqft
lint
7d9aaac
@xqft
remove arrayvec
b6cc6f6
@xqft
remove arrayvec import
0641b1f
@xqft
Merge branch 'main' into l2/opt_trie_hashes
1e933b7
@xqft
add comment to memoize_hashes and rename
fa6cd12
@xqft
simplify memoize
24b6804
@xqft
remove fast rlp
5d3fa97
@xqft xqft changed the title chore(l2): temp! all trie optimizations temp(l1,l2): temp! all trie optimizations Oct 17, 2025
@xqft xqft changed the title temp(l1,l2): temp! all trie optimizations temp(l1,l2): all trie optimizations Oct 17, 2025
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Oct 17, 2025
@github-actions
Copy link

Benchmark for 1611712

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 36.8±2.91ms 36.5±1.92ms -0.82%
Trie/cita-trie insert 1k 3.5±0.02ms 3.5±0.02ms 0.00%
Trie/ethrex-trie insert 10k 63.1±0.82ms 48.2±0.82ms -23.61%
Trie/ethrex-trie insert 1k 8.1±0.07ms 6.9±0.04ms -14.81%

@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

Lines of code report

Total lines added: 312
Total lines removed: 0
Total lines changed: 312

Detailed view 
+---------------------------------------------+-------+------+
| File                                        | Lines | Diff |
+---------------------------------------------+-------+------+
| ethrex/crates/common/rlp/encode.rs          | 527   | +16  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/rlp/structs.rs         | 200   | +37  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/nibbles.rs        | 336   | +30  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node.rs           | 387   | +141 |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/branch.rs    | 537   | +8   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/extension.rs | 454   | +23  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/leaf.rs      | 291   | +25  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node_hash.rs      | 125   | +16  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/trie.rs           | 929   | +15  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/trie_iter.rs      | 207   | +1   |
+---------------------------------------------+-------+------+

@github-actions
Copy link

Benchmark for 40ae3d2

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 34.7±0.22ms 35.5±0.83ms +2.31%
Trie/cita-trie insert 1k 3.6±0.01ms 3.5±0.02ms -2.78%
Trie/ethrex-trie insert 10k 61.5±1.75ms 47.5±1.39ms -22.76%
Trie/ethrex-trie insert 1k 8.0±0.14ms 6.9±0.06ms -13.75%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@xqft xqft

Labels

L1 Ethereum client L2 Rollup client

Projects

ethrex_l1
Status: No status
ethrex_l2
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xqft @edg-l