Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move blob operations to blobs module #1404

Merged
merged 19 commits into from
Apr 1, 2025
Merged

Conversation

LeanSerra
Copy link
Contributor

@LeanSerra LeanSerra commented Mar 26, 2025

Note

The CI was failing due to the latest version of protoc-gen-go requiring go>=1.22 the go version is bumped in this PR

Motivation

  • Simplify pending blocks, making it more readable.
  • Make the blob db more testable.

Description

Move all blob related functions from /beacon/pending_blocks.ex to /store/blobs.ex

Closes #1128

@LeanSerra LeanSerra added the refactor Ideas to improve code usability or performance with little or no change to behavior label Mar 26, 2025
@LeanSerra LeanSerra self-assigned this Mar 26, 2025
@LeanSerra LeanSerra marked this pull request as ready for review March 27, 2025 17:37
@LeanSerra LeanSerra requested a review from a team as a code owner March 27, 2025 17:37
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just left some minor comments!

Comment on lines +14 to +16
Application.fetch_env!(:lambda_ethereum_consensus, ChainSpec)
|> Keyword.put(:config, MainnetConfig)
|> then(&Application.put_env(:lambda_ethereum_consensus, ChainSpec, &1))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rodrigo-o rodrigo-o merged commit 35d4c18 into main Apr 1, 2025
14 checks passed
@rodrigo-o rodrigo-o deleted the refactor/blob_module branch April 1, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Ideas to improve code usability or performance with little or no change to behavior
Projects
Development

Successfully merging this pull request may close these issues.

Move Blob operations from PendingBlocks to a Blob module
3 participants