feat: beacon api block headers #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested changes
Jan 17, 2024
Comment on lines
+113
to
+114
| @spec get_block_headers(Plug.Conn.t(), any) :: Plug.Conn.t() | ||
| def get_block_headers(conn, %{"slot" => slot, "parent_root" => parent_root} = _params) do |
There was a problem hiding this comment.
I think this function isn't used anywhere 🤔
| proposer_index: signed_block.message.proposer_index, | ||
| parent_root: signed_block.message.parent_root, | ||
| state_root: signed_block.message.state_root, | ||
| body_root: root |
There was a problem hiding this comment.
The body root should be the root of the block's body, not the whole block's
|
Closing but adding a reference to the ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements the block header related endpoints of the Beacon API.
Closes #561