-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hydration dependency #35
base: 2.5.x
Are you sure you want to change the base?
Fix hydration dependency #35
Conversation
@datasage looks like some of your commits need to be signed off: https://github.com/laminas-api-tools/api-tools-doctrine/pull/35/checks?check_run_id=10399596166 |
I will look at getting this handed
My goal was to address the immediate dependency issues with minimal code changes needed to address any compatibility issues. There are certainly further improvements that could be made, such as fully refactoring away from phpro/zf-doctrine-hydration-module (I switched to a forked one for now with minimal updates to avoid any breaks). |
…ew version that is now current. - Due to transitive dependencies PHP 7.4 will be new minimum. Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
…sue with test combination. Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
4e50034
to
f6e8bde
Compare
Description
The work in this branch targets the abandoned dependency of phpro/zf-doctrine-hydration-module along with any other changes necessary to allow an updated version of the dependency to work with this library. I've taken the abandoned dependency and forked it.
When possible a range of versions were used in dependencies. The most significant changes are the following:
There is some more work to be done. Such as fixing incomplete tests, fixing psalm errors, etc. My goal was to keep the changes limited and address some of those other issues in additional PR's.