Upgrade to laminas/laminas-servicemanager to v4.1.0 in branch 3.9.x #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It won't be possible to upgrade to SMv4 here until all of the hard dependencies support SMv4. It's also a BC break for all plugin manager implementations (i.e. ControllerPluginManager), therefore this couldn't possibly go into 3.9.x - it will have to go into the next major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to upgrade
laminas/laminas-servicemanagerto^4.1.0version.Methods signatures inherithed from
Laminas\ServiceManager::AbstractPluginManagerare updated.Every call to phpunit static "assert" methods are updated as well.