Optimize code #75
Closed
Optimize code #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Geert Eltink <[email protected]>
When calling `create()` outside of the `processPostData()` method (analog to `processBodyContent`) we can override the method to change the behaviour of parsing POST-Params and also getting the result back and not the response of the action. All other cases `GET`, `PUT`, `PATCH` and `DELETE` also calls their similar method in directly in the `onDispatch()` method. These changes doesn't infect the workflow. It's just a small code optimization. Signed-off-by: Martin Seysen <[email protected]>
|
While I think this is a good change, it's also a BC break, as it changes the behavior of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
create()outside of theprocessPostData()method (analog toprocessBodyContent()) we can override the method to change the behaviour of parsing POST-Params and also getting the result back and not the response of the action. All other casesGET,PUT,PATCHandDELETEalso calls their similar method in directly in theonDispatch()method.These changes doesn't infect the workflow. It's just a small code optimization.