Skip to content

Upgrade composer.json to allow PHP 8.4 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

RalfEggert
Copy link

Add PHP 8.4 version for #42

@froschdesign
Copy link
Member

@RalfEggert
The problem here is Psalm.

Please extend the file .laminas-ci.json:

{
    "ignore_php_platform_requirements": {
        "8.4": true
    },
    "backwardCompatibilityCheck": true
}

@RalfEggert
Copy link
Author

@froschdesign

Ok, is it better?

@nicklog
Copy link

nicklog commented Dec 17, 2024

I would be very grateful if something could be done here :)

@mimmi20
Copy link
Contributor

mimmi20 commented Jan 27, 2025

@RalfEggert Could you solve these issues?

@froschdesign
Copy link
Member

The issues are listed in the checks:

There is also a hint:

Psalm can automatically fix 13 of these issues.
Run Psalm again with 
--alter --issues=InvalidReturnType,MissingReturnType,PossiblyUnusedMethod --dry-run
to see what it can fix.

@gsteel gsteel self-assigned this Feb 10, 2025
@gsteel
Copy link
Member

gsteel commented Feb 10, 2025

Closed via #46

@gsteel gsteel closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants