-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub actions CI #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These could also be replaced with actions that do this automatically, not sure which we prefer?
I quite like being able to run them as commands!
Test coverage - Need tests to be added first
Fair enough
README rendering - Didn't find a nice action for this, if we want it can either switch to .Rmd or custom build one
I'm happy to add it as a PR command. WDYT? Can pick this up in a separate issue if need be
pkgdown rendering - Need to set up pkgdown first
True!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait no. Can you add something to the CHANGELOG.md? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #6
Adds:
Doesn't add:
README
rendering - Didn't find a nice action for this, if we want it can either switch to.Rmd
or custom build onepkgdown
rendering - Need to set uppkgdown
first