Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions CI #11

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Add GitHub actions CI #11

merged 6 commits into from
Oct 4, 2024

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented Oct 4, 2024

Closes #6

Adds:

  • Standard package check action
  • Linting action
  • Commands for documenting and styling using comments on PRs
    • These could also be replaced with actions that do this automatically, not sure which we prefer?

Doesn't add:

  • Test coverage - Need tests to be added first
  • README rendering - Didn't find a nice action for this, if we want it can either switch to .Rmd or custom build one
  • pkgdown rendering - Need to set up pkgdown first

@lazappi lazappi requested a review from rcannood October 4, 2024 10:34
Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

These could also be replaced with actions that do this automatically, not sure which we prefer?

I quite like being able to run them as commands!

Test coverage - Need tests to be added first

Fair enough

README rendering - Didn't find a nice action for this, if we want it can either switch to .Rmd or custom build one

I'm happy to add it as a PR command. WDYT? Can pick this up in a separate issue if need be

pkgdown rendering - Need to set up pkgdown first

True!

Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no. Can you add something to the CHANGELOG.md? 😬

Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit f6d5dcc into main Oct 4, 2024
6 checks passed
@rcannood rcannood deleted the ci branch October 4, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CI (unit testing and linting)
2 participants