Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Todo Rule #35

Merged
merged 4 commits into from
Mar 27, 2025
Merged

feat: Todo Rule #35

merged 4 commits into from
Mar 27, 2025

Conversation

lanesawyer
Copy link
Owner

@lanesawyer lanesawyer commented Mar 25, 2025

feat: Todo Rule

Why

Provide a brief description of why this PR is necessary.

What

Provide a brief description of what this PR does.

How

Provide a brief description of how the new code works.

Testing

Provide a brief description of any manual testing steps necessary and any automated tests that were added.

PR Checklist

  • I have read the CONTRIBUTING.md document.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • Tests, linting, and formatting checks pass.

problems
}

pub fn include(&self) -> Option<Vec<Regex>> {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is identical to the Regex one. How can I make it so that each has a default implementation in a better way?

@lanesawyer lanesawyer marked this pull request as ready for review March 27, 2025 05:56
@lanesawyer lanesawyer merged commit 4a9b363 into main Mar 27, 2025
8 checks passed
@lanesawyer lanesawyer deleted the lane/rule-config-update branch March 27, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant