New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Compare function didn't pick up existing rule #40

Merged

lanesawyer merged 2 commits into main from lane/fix-comparison

Mar 26, 2025

Owner

lanesawyer commented Mar 26, 2025

fix: Compare function didn't pick up existing rule

Fixes #37

Why

There was a bug when the file already had items

What

Better compare of the rules map

How

Check for totals in a smarter way

Testing

Existing tests cover it, although I did find a small issue that I fixed

PR Checklist

I have read the CONTRIBUTING.md document.
I have added tests that prove my fix is effective or that my feature works.
I have added necessary documentation (if appropriate).
Tests, linting, and formatting checks pass.

lanesawyer added 2 commits

March 25, 2025 23:40


          fix: Compare function didn't pick up existing rule

d09deb1


          fmt and remove a log

da579da

lanesawyer merged commit bbe2ab4 into main

8 checks passed

lanesawyer deleted the lane/fix-comparison branch

March 27, 2025 05:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet