fix(run_ingest): Use dictionary key to access run ID#40
Open
Yunus Emre KORKMAZ (dolphinium) wants to merge 1 commit into
Open
fix(run_ingest): Use dictionary key to access run ID#40Yunus Emre KORKMAZ (dolphinium) wants to merge 1 commit into
Yunus Emre KORKMAZ (dolphinium) wants to merge 1 commit into
Conversation
The `client.runs.list` method returns a list of dictionaries, where each dictionary represents a run. The previous code attempted to access the run ID using attribute access (`run_info.id`), which caused an `AttributeError` because dictionaries do not have attributes. This commit changes the access method to use the correct dictionary key (`run_info["run_id"]`) to retrieve the run ID. This resolves the bug that occurred when cleaning up previous runs from a thread, allowing the email ingestion process to complete successfully.
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
client.runs.listmethod returns a list of dictionaries, where each dictionary represents a run. The previous code attempted to access the run ID using attribute access (run_info.id), which caused anAttributeErrorbecause dictionaries do not have attributes.This commit changes the access method to use the correct dictionary key (
run_info["run_id"]) to retrieve the run ID. This resolves the bug that occurred when cleaning up previous runs from a thread, allowing the email ingestion process to complete successfully.