fix: checks for s3 pre-signed buckets #367
Open
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous commit, I fixed the regex that did not capture s3 bucket url structure and failed to distinguish presigned urls. However, I realized that just fixing the regex is not enough as now it does not distinguish between public and presigned s3 buckets. so I introduced an improved check that only filters presigned buckets.
fix: check for presigned url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pdf document loader had checks in place to determine if a url is a presigned url. However, this check was not working, first and foremost, because the regex was not capturing the s3 regex correctly. The presinged url failed the check and was processed as a normal url, which resulted in OSError: filename too long. However, just fixing the url would not allow to distinguish between public and presigned s3 buckets. I rewrote the method to correctly determine whether a url is specifically a presigned bucket (to be further processed accordingly).