feat: cloudflare-sqlite for durable objects #787
Conversation
|
Very nice! A bit bogged down but will look next week after the holiday. |
|
@mattzcarey great to see this come through! Can you please add this to the tests in the |
|
Hey @benjamincburns, not sure how I can do that since the sqlite api doesnt really exist outside of durable objects. I'll see if I can get someone for them CF team to help. |
|
I'm going to try and take a look at this |
|
@threepointone LMK if you have any questions! |
| start:node: 3, | ||
| node: 3 | ||
| }, | ||
| versions_seen: { | ||
| __input__: {}, | ||
| __start__: { | ||
| __start__: 1 | ||
| }, | ||
| node: { | ||
| start:node: 2 |
There was a problem hiding this comment.
Fixed invalid JSON
| start:node: 3, | |
| node: 3 | |
| }, | |
| versions_seen: { | |
| __input__: {}, | |
| __start__: { | |
| __start__: 1 | |
| }, | |
| node: { | |
| start:node: 2 | |
| "start:node": 3, | |
| node: 3 | |
| }, | |
| versions_seen: { | |
| __input__: {}, | |
| __start__: { | |
| __start__: 1 | |
| }, | |
| node: { | |
| "start:node": 2 |
| const pendingWrites = await Promise.all( | ||
| (() => { | ||
| try { | ||
| return JSON.parse(String(row.pending_writes || '[]')) as PendingWriteColumn[]; |
There was a problem hiding this comment.
What's the purpose of the stringification and parsing that requires the type assertion? Is there a way to add a type guard to ensure the structure of row.pending_writes rather than forcing it?
| const pending_sends = await Promise.all( | ||
| (() => { | ||
| try { | ||
| return JSON.parse(String(row.pending_sends || '[]')) as PendingSendColumn[]; |
| console.error('Failed to parse pending writes:', e); | ||
| return []; | ||
| } | ||
| })().map(async (write) => { |
There was a problem hiding this comment.
This IIFE is a little hard to read, would you be able to separate the promise resolution from the iterations?
| console.error('Failed to parse pending sends:', e); | ||
| return []; | ||
| } | ||
| })().map(async (send) => await this.serde.loadsTyped(send.type ?? 'json', send.value ?? '')) |
Cloudflare durable objects have a slightly different sqlite api.
Tests are not passing cause I am getting some weird esm errors, but this works for me in a durable object.
Have a great weekend,
Matt