fix: replace placeholder gist ID with actual gist ID for benchmark badges#84
Merged
fix: replace placeholder gist ID with actual gist ID for benchmark badges#84
Conversation
…dges The squash merge of #83 included the placeholder 'public_gists' string instead of the actual gist ID (0fcf197a0e717817dbeb34d146db423e). This caused the 'Update benchmark badges' CI step to fail with exit code 22 (curl 404) and the shields.io badges to show 'resource not found'.
Benchmark results
Budget: regex/cache < 2.5ms (0.5% of 500ms baseline), streaming < 20ms (4% of 500ms baseline) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The squash merge of #83 included the placeholder
public_gistsstring instead of the actual gist ID. This caused the CIUpdate benchmark badgesstep to fail with exit code 22 (curl 404) and the shields.io badges to showresource not found.Replaces
public_gistswith0fcf197a0e717817dbeb34d146db423ein:README.md(2 badge URLs).github/workflows/ci.yml(gist update script argument)