Skip to content

Fixed deprecation notice for php 8.4 #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
+16 −3
Open

Fixed deprecation notice for php 8.4 #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,12 @@ parameters:
path: src/Console/DumpDatabaseCommand.php

-
message: "#^Parameter \\#1 \\$em of method LaravelDoctrine\\\\ORM\\\\Console\\\\DumpDatabaseCommand\\:\\:dump\\(\\) expects string, array\\|bool\\|string\\|null given\\.$#"
message: "#^Parameter \\#1 \\$em of method LaravelDoctrine\\\\ORM\\\\Console\\\\DumpDatabaseCommand\\:\\:dump\\(\\) expects string, array\\|string\\|true given\\.$#"
count: 1
path: src/Console/DumpDatabaseCommand.php

-
message: "#^Parameter \\#2 \\$em of method LaravelDoctrine\\\\ORM\\\\Console\\\\DumpDatabaseCommand\\:\\:connect\\(\\) expects string, array\\|bool\\|string\\|null given\\.$#"
message: "#^Parameter \\#2 \\$em of method LaravelDoctrine\\\\ORM\\\\Console\\\\DumpDatabaseCommand\\:\\:connect\\(\\) expects string, array\\|string\\|true given\\.$#"
count: 1
path: src/Console/DumpDatabaseCommand.php

Expand Down Expand Up @@ -525,6 +525,14 @@ parameters:
count: 3
path: src/DoctrineServiceProvider.php

-
message: """
#^Call to method register\\(\\) of deprecated class Doctrine\\\\Common\\\\Proxy\\\\Autoloader\\:
The Autoloader class is deprecated since doctrine/common 3\\.5\\.$#
"""
count: 1
path: src/DoctrineServiceProvider.php

-
message: "#^Call to static method create\\(\\) on an unknown class Faker\\\\Factory\\.$#"
count: 1
Expand Down Expand Up @@ -1163,6 +1171,11 @@ parameters:
count: 1
path: src/Pagination/PaginatorAdapter.php

-
message: "#^Method LaravelDoctrine\\\\ORM\\\\Pagination\\\\PaginatorAdapter\\:\\:convertToLaravelPaginator\\(\\) return type with generic class Illuminate\\\\Pagination\\\\LengthAwarePaginator does not specify its types\\: TKey, TValue$#"
count: 1
path: src/Pagination/PaginatorAdapter.php

-
message: "#^Method LaravelDoctrine\\\\ORM\\\\Pagination\\\\PaginatorAdapter\\:\\:fromParams\\(\\) has parameter \\$queryParams with no value type specified in iterable type array\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/Extension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ interface Extension
* @param EntityManagerInterface $em
* @param Reader|null $reader
*/
public function addSubscribers(EventManager $manager, EntityManagerInterface $em, Reader $reader = null);
public function addSubscribers(EventManager $manager, EntityManagerInterface $em, ?Reader $reader = null);

/**
* @return array
Expand Down
Loading