Update undocumented precision in documentation #10381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Number helper class currency method precision not documented, but exist in the code, there is a lot of currency that do not use any subb currency Like (HUF)
|
I think 10 or 11 when introduced need to be also change like 11.x or 10.x i dont know exactly when. but its very use full, and i have idea about set default precision based on local. |
shaedrich
reviewed
May 12, 2025
There was a problem hiding this comment.
there is a lot of currency that do not use any subb currency Like (HUF)
As discussed in laravel/framework#54456, it might be interesting to add the cases where this might be used to the documentation
| @@ -1552,6 +1552,10 @@ $currency = Number::currency(1000, in: 'EUR'); | |||
| $currency = Number::currency(1000, in: 'EUR', locale: 'de'); | |||
|
|
|||
| // 1.000,00 € | |||
|
|
|||
There was a problem hiding this comment.
Wouldn't it make sense to have a descriptive paragraph here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Number helper class currency method precision not documented, but exist in the code, there is a lot of currency that do not use any subb currency Like (HUF)