feat(task): add resource agent & agent_task_step_info#693
feat(task): add resource agent & agent_task_step_info#693liangshuo-1 merged 1 commit intolarksuite:mainfrom
Conversation
|
|
github-actions
Bot
added
domain/task
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-task/SKILL.md (1)
161-164:⚠️ Potential issue | 🔴 CriticalAdd missing authoritative scope definitions for agent methods.
The three new methods (
agent.update_agent_profile,agent.register_agent,agent_task_step_info.append_task_steps) are documented in the SKILL.md permission table withtask:task:writescope, but they have no entries in the authoritative scope registries (scope_priorities.json,scope_overrides.json, ormeta_data_default.json).Without these definitions, CLI auth will not recognize these scopes and the feature will fail at runtime. Either add the scope definitions to the registry files or remove these rows from the documentation table if they are not yet implemented.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-task/SKILL.md` around lines 161 - 164, The SKILL.md adds three new methods (agent.update_agent_profile, agent.register_agent, agent_task_step_info.append_task_steps) but they are missing authoritative scope entries; add corresponding scope definitions for "task:task:write" to your scope registries (scope_priorities.json, scope_overrides.json, and meta_data_default.json) so CLI auth recognizes them — specifically, add entries mapping each method symbol to the "task:task:write" scope in scope_priorities.json (with appropriate priority), include any required override entries in scope_overrides.json, and add default metadata entries in meta_data_default.json; alternatively, if these methods aren’t implemented yet, remove the three rows from SKILL.md instead of modifying the registries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-task/SKILL.md`:
- Around line 117-121: The bullet entries for the agent methods include an H2
markdown token ("## 功能介绍") inside list items which breaks rendering; edit the
`update_agent_profile` and `register_agent` entries to remove the "## 功能介绍"
heading and convert it into inline explanatory text (e.g. "功能介绍：更新任务代理的主页内容数据。"
or move a single "功能介绍" heading above the agent list) so the list items remain
normal bullets and descriptions render correctly.
---
Outside diff comments:
In `@skills/lark-task/SKILL.md`:
- Around line 161-164: The SKILL.md adds three new methods
(agent.update_agent_profile, agent.register_agent,
agent_task_step_info.append_task_steps) but they are missing authoritative scope
entries; add corresponding scope definitions for "task:task:write" to your scope
registries (scope_priorities.json, scope_overrides.json, and
meta_data_default.json) so CLI auth recognizes them — specifically, add entries
mapping each method symbol to the "task:task:write" scope in
scope_priorities.json (with appropriate priority), include any required override
entries in scope_overrides.json, and add default metadata entries in
meta_data_default.json; alternatively, if these methods aren’t implemented yet,
remove the three rows from SKILL.md instead of modifying the registries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
bytedance-zxy
force-pushed
the
feat-aliy-tas
branch
from
f6e5a44 to
45df9bb
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/lark-task/SKILL.md (1)
119-120:⚠️ Potential issue | 🟡 MinorRemove
##heading tokens from list item descriptions.At Line 119 and Line 124, embedding
## 功能介绍inside bullets introduces heading syntax in list content. Keep these as plain inline descriptions.🛠️ Suggested doc fix
- - `update_agent_profile` — ## 功能介绍 更新任务代理的主页内容数据。 + - `update_agent_profile` — 功能介绍：更新任务代理的主页内容数据。 - `register_agent` — 注册/注销 AI 智能体 @@ - - `append_task_steps` — ## 功能介绍 写入任务记录。 + - `append_task_steps` — 功能介绍：写入任务记录。Also applies to: 124-124
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-task/SKILL.md` around lines 119 - 120, Remove the accidental markdown heading tokens inside the list items for update_agent_profile and register_agent: change entries that read like "`update_agent_profile` — ## 功能介绍 更新任务代理的主页内容数据。" and "`register_agent` — 注册/注销 AI 智能体" (if it contains `##`) to plain inline descriptions without the "##" token so they read e.g. "`update_agent_profile` — 功能介绍 更新任务代理的主页内容数据。" and "`register_agent` — 注册/注销 AI 智能体`", ensuring no heading syntax remains in the bullet text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@skills/lark-task/SKILL.md`:
- Around line 119-120: Remove the accidental markdown heading tokens inside the
list items for update_agent_profile and register_agent: change entries that read
like "`update_agent_profile` — ## 功能介绍 更新任务代理的主页内容数据。" and "`register_agent` —
注册/注销 AI 智能体" (if it contains `##`) to plain inline descriptions without the
"##" token so they read e.g. "`update_agent_profile` — 功能介绍 更新任务代理的主页内容数据。" and
"`register_agent` — 注册/注销 AI 智能体`", ensuring no heading syntax remains in the
bullet text.
45df9bb to
e598c1b
Compare
Change-Id: I3b2d8ee72361aee9b68a5bbbafcf594f220d3105
bytedance-zxy
force-pushed
the
feat-aliy-tas
branch
from
e598c1b to
b0daeee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 63.10% 64.14% +1.03%
==========================================
Files 437 504 +67
Lines 38927 44285 +5358
==========================================
+ Hits 24565 28406 +3841
- Misses 12187 13411 +1224
- Partials 2175 2468 +293 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@b0daeee227ad69ba29c8d912a64b27f71001c823🧩 Skill updatenpx skills add bytedance-zxy/cli#feat-aliy-tas -y -g |
4 participants
feat(task): add agent and agent_task_step_info API resources to SKILL.md
Add documentation for new task API resources:
Also add corresponding scope permissions to the permission table.
Summary by CodeRabbit
Documentation
New Features