Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/auth/login.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,10 @@ func authLoginRun(opts *LoginOptions) error {
fmt.Fprintf(f.IOStreams.ErrOut, "[lark-cli] [WARN] auth login: failed to cache requested scopes: %v\n", err)
}
data := map[string]interface{}{
"verification_url": authResp.VerificationUriComplete,
"verification_url": "[`" + authResp.VerificationUriComplete + "`](" + authResp.VerificationUriComplete + ")",
"device_code": authResp.DeviceCode,
"expires_in": authResp.ExpiresIn,
"hint": fmt.Sprintf("Show verification_url to user, then immediately execute: lark-cli auth login --device-code %s (blocks until authorized or timeout). Do not instruct the user to run this command themselves.", authResp.DeviceCode),
"hint": fmt.Sprintf("Show verification_url to the user verbatim. It is pre-formatted as a markdown link `[`URL`](URL)`: the inner backticks render the URL as inline code so emphasis parsing cannot mangle underscores, while the outer link wrapper keeps it clickable. Do not unwrap, escape, or rewrite any part. Then immediately execute: lark-cli auth login --device-code %s (blocks until authorized or timeout). Do not instruct the user to run this command themselves.", authResp.DeviceCode),
}
encoder := json.NewEncoder(f.IOStreams.Out)
encoder.SetEscapeHTML(false)
Expand Down
196 changes: 196 additions & 0 deletions cmd/auth/login_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,202 @@ func TestAuthLoginRun_JSONWriteFailure_DeviceAuthorizationReturnsWriterError(t *
}
}

func TestAuthLoginRun_NoWaitJSONWrapsVerificationURLAsCodedLink(t *testing.T) {
keyring.MockInit()
setupLoginConfigDir(t)

f, stdout, _, reg := cmdutil.TestFactory(t, &core.CliConfig{
ProfileName: "default",
AppID: "cli_test",
AppSecret: "secret",
Brand: core.BrandFeishu,
})

const completeURL = "https://example.com/verify?state=abc_def_ghi&scope=mail:user_mailbox:readonly"
reg.Register(&httpmock.Stub{
Method: "POST",
URL: larkauth.PathDeviceAuthorization,
Body: map[string]interface{}{
"device_code": "device-code",
"user_code": "user-code",
"verification_uri": "https://example.com/verify",
"verification_uri_complete": completeURL,
"expires_in": 240,
"interval": 0,
},
})

err := authLoginRun(&LoginOptions{
Factory: f,
Ctx: context.Background(),
Scope: "im:message:send",
NoWait: true,
})
if err != nil {
t.Fatalf("authLoginRun() error = %v", err)
}

var payload map[string]interface{}
if err := json.Unmarshal(stdout.Bytes(), &payload); err != nil {
t.Fatalf("unmarshal stdout: %v\nstdout: %s", err, stdout.String())
}
got, ok := payload["verification_url"].(string)
if !ok {
t.Fatalf("verification_url missing or not string: %#v", payload)
}
want := "[`" + completeURL + "`](" + completeURL + ")"
if got != want {
t.Fatalf("verification_url = %q,\nwant %q\n(--no-wait wraps URL as [`URL`](URL): backticks shield text from emphasis parsing, link wrapper provides clickability)", got, want)
}
}

func TestAuthLoginRun_NoWaitHintInstructsVerbatimDisplay(t *testing.T) {
keyring.MockInit()
setupLoginConfigDir(t)

f, stdout, _, reg := cmdutil.TestFactory(t, &core.CliConfig{
ProfileName: "default",
AppID: "cli_test",
AppSecret: "secret",
Brand: core.BrandFeishu,
})

reg.Register(&httpmock.Stub{
Method: "POST",
URL: larkauth.PathDeviceAuthorization,
Body: map[string]interface{}{
"device_code": "device-code",
"user_code": "user-code",
"verification_uri": "https://example.com/verify",
"verification_uri_complete": "https://example.com/verify?state=a_b_c",
"expires_in": 240,
"interval": 0,
},
})

err := authLoginRun(&LoginOptions{
Factory: f,
Ctx: context.Background(),
Scope: "im:message:send",
NoWait: true,
})
if err != nil {
t.Fatalf("authLoginRun() error = %v", err)
}

var payload map[string]interface{}
if err := json.Unmarshal(stdout.Bytes(), &payload); err != nil {
t.Fatalf("unmarshal stdout: %v", err)
}
hint, _ := payload["hint"].(string)
for _, want := range []string{
"verification_url",
"verbatim",
"backtick",
} {
if !strings.Contains(hint, want) {
t.Fatalf("hint missing %q, got: %s", want, hint)
}
}
}

func TestAuthLoginRun_InteractiveJSONKeepsRawURL(t *testing.T) {
keyring.MockInit()
setupLoginConfigDir(t)

original := pollDeviceToken
t.Cleanup(func() { pollDeviceToken = original })
pollDeviceToken = func(_ context.Context, _ *http.Client, _, _ string, _ core.LarkBrand, _ string, _, _ int, _ io.Writer) *larkauth.DeviceFlowResult {
return &larkauth.DeviceFlowResult{OK: false, Message: "stub"}
}

f, stdout, _, reg := cmdutil.TestFactory(t, &core.CliConfig{
ProfileName: "default",
AppID: "cli_test",
AppSecret: "secret",
Brand: core.BrandFeishu,
})

const completeURL = "https://example.com/verify?state=a_b_c&scope=mail:user_mailbox:readonly"
reg.Register(&httpmock.Stub{
Method: "POST",
URL: larkauth.PathDeviceAuthorization,
Body: map[string]interface{}{
"device_code": "device-code",
"user_code": "user-code",
"verification_uri": "https://example.com/verify",
"verification_uri_complete": completeURL,
"expires_in": 240,
"interval": 0,
},
})

_ = authLoginRun(&LoginOptions{
Factory: f,
Ctx: context.Background(),
Scope: "im:message:send",
JSON: true,
})

dec := json.NewDecoder(strings.NewReader(stdout.String()))
var first map[string]interface{}
if err := dec.Decode(&first); err != nil {
t.Fatalf("decode first JSON event: %v\nstdout: %s", err, stdout.String())
}
if first["verification_uri_complete"] != completeURL {
t.Fatalf("verification_uri_complete = %v, want raw URL %q", first["verification_uri_complete"], completeURL)
}
if _, exists := first["verification_uri_complete_markdown"]; exists {
t.Fatalf("interactive --json must not add markdown field; only --no-wait wraps URL. payload: %#v", first)
}
}

func TestAuthLoginRun_PlainTextStderrShowsBareURL(t *testing.T) {
keyring.MockInit()
setupLoginConfigDir(t)

original := pollDeviceToken
t.Cleanup(func() { pollDeviceToken = original })
pollDeviceToken = func(_ context.Context, _ *http.Client, _, _ string, _ core.LarkBrand, _ string, _, _ int, _ io.Writer) *larkauth.DeviceFlowResult {
return &larkauth.DeviceFlowResult{OK: false, Message: "stub"}
}

f, _, stderr, reg := cmdutil.TestFactory(t, &core.CliConfig{
ProfileName: "default",
AppID: "cli_test",
AppSecret: "secret",
Brand: core.BrandFeishu,
})

const completeURL = "https://example.com/verify?state=a_b_c"
reg.Register(&httpmock.Stub{
Method: "POST",
URL: larkauth.PathDeviceAuthorization,
Body: map[string]interface{}{
"device_code": "device-code",
"user_code": "user-code",
"verification_uri": "https://example.com/verify",
"verification_uri_complete": completeURL,
"expires_in": 240,
"interval": 0,
},
})

_ = authLoginRun(&LoginOptions{
Factory: f,
Ctx: context.Background(),
Scope: "im:message:send",
})

got := stderr.String()
if !strings.Contains(got, " "+completeURL+"\n") {
t.Fatalf("stderr missing bare URL line, got:\n%s", got)
}
if strings.Contains(got, "<"+completeURL+">") {
t.Fatalf("stderr should not contain autolink form for human users, got:\n%s", got)
}
}

func TestGetDomainMetadata_ExcludesEvent(t *testing.T) {
domains := getDomainMetadata("zh")
for _, dm := range domains {
Expand Down
Loading