fix(vc): parse meet_number from video_chat with word labels#514
Merged
Conversation
de914c1 to
c00a98a
Compare
evandance
approved these changes
May 15, 2026
Collaborator
evandance
left a comment
There was a problem hiding this comment.
LGTM. The meet_number field was filtered out at the parsed-type boundary; widening the inline type and guarding render with if (meetingNo) is the right minimal fix. The emoji → word-label drive-by is well-motivated against agent name-drift. Non-blocking nit: convertVideoChat has no fixture in tests/ today — a small unit test would lock in the new field and label. Approving.
evandance
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertVideoChat之前只解析topic和start_time,丢失了消息体里的meet_number字段,导致<meeting>块对下游 Agent 不可见会议号,无法与 VC 事件路径里的同一会议关联或据此入会。video_chatpayload schema 中补上meet_number;同时把<meeting>块的字段标签从 emoji icon (📹/🕙/🆔) 改为英文词标签 (Topic:/Start time:/Meeting number:),让下游 Agent 收到的语义更明确(端到端验证时观察到 agent 会把🆔二次翻译为meeting_id,词标签可避免这种命名漂移)。Test plan
video_chat消息,验证<meeting>块包含Meeting number: <会议号>行meet_number缺失时回退到原有输出,不出现空Meeting number:行