Skip to content

fix(vc): parse meet_number from video_chat with word labels#514

Merged
evandance merged 1 commit into
mainfrom
fix/vc-card-parse-meeting-no
May 15, 2026
Merged

fix(vc): parse meet_number from video_chat with word labels#514
evandance merged 1 commit into
mainfrom
fix/vc-card-parse-meeting-no

Conversation

@Ren1104
Copy link
Copy Markdown
Collaborator

@Ren1104 Ren1104 commented May 15, 2026

Summary

  • convertVideoChat 之前只解析 topicstart_time,丢失了消息体里的 meet_number 字段,导致 <meeting> 块对下游 Agent 不可见会议号,无法与 VC 事件路径里的同一会议关联或据此入会。
  • 本次在 video_chat payload schema 中补上 meet_number;同时把 <meeting> 块的字段标签从 emoji icon (📹 / 🕙 / 🆔) 改为英文词标签 (Topic: / Start time: / Meeting number:),让下游 Agent 收到的语义更明确(端到端验证时观察到 agent 会把 🆔 二次翻译为 meeting_id,词标签可避免这种命名漂移)。
  • 各字段均按"非空才输出"渲染,向后兼容现有消费者。

Test plan

  • 本地构造 video_chat 消息,验证 <meeting> 块包含 Meeting number: <会议号>
  • meet_number 缺失时回退到原有输出,不出现空 Meeting number:
  • 端到端验证:飞书发起会议邀请卡片,Agent 能从消息中读到会议号(实测会议号 311763680 / 777242820 均被 agent 准确报出)

@Ren1104 Ren1104 force-pushed the fix/vc-card-parse-meeting-no branch from de914c1 to c00a98a Compare May 15, 2026 09:03
@Ren1104 Ren1104 changed the title fix(vc): parse meet_number from video_chat message payload fix(vc): parse meet_number from video_chat with word labels May 15, 2026
@Ren1104 Ren1104 requested a review from evandance May 15, 2026 09:20
Copy link
Copy Markdown
Collaborator

@evandance evandance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The meet_number field was filtered out at the parsed-type boundary; widening the inline type and guarding render with if (meetingNo) is the right minimal fix. The emoji → word-label drive-by is well-motivated against agent name-drift. Non-blocking nit: convertVideoChat has no fixture in tests/ today — a small unit test would lock in the new field and label. Approving.

@evandance evandance added bug Something isn't working messaging src/messaging/ + src/card/ — message rendering, cards, streaming labels May 15, 2026
@evandance evandance merged commit b5f9ff7 into main May 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working messaging src/messaging/ + src/card/ — message rendering, cards, streaming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants