Skip to content

Fallback to current Feishu message for reactions#536

Open
zhulijin1991 wants to merge 3 commits into
larksuite:mainfrom
zhulijin1991:codex/lark-reaction-defaults
Open

Fallback to current Feishu message for reactions#536
zhulijin1991 wants to merge 3 commits into
larksuite:mainfrom
zhulijin1991:codex/lark-reaction-defaults

Conversation

@zhulijin1991

Copy link
Copy Markdown
Contributor

Summary

  • Keep this PR focused on reaction message-id resolution only.
  • Let react / reactions fall back to toolContext.currentMessageId when callers omit messageId / message_id.
  • Remove the runtime emoji alias map from this branch so canonical Feishu reaction names are never silently rewritten.

Validation

  • pnpm exec vitest run tests/reaction-defaults.test.ts
  • pnpm run typecheck
  • pnpm exec prettier --check src/messaging/outbound/actions.ts tests/reaction-defaults.test.ts
  • git diff --check

Follow-up

Emoji-shape guidance should be handled separately in tool schema/description wording, without hidden runtime rewrites such as HEART -> LOVE or CLAP -> APPLAUSE.


Restored from closed PR: #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant