Prevent infinite recursion in python variable logger#589
Merged
patkenneally merged 2 commits intodevelopfrom Mar 23, 2026
Merged
Conversation
JulianHammerl
approved these changes
Mar 23, 2026
patkenneally
force-pushed
the
fix/2110-prevent-inifinite-recursion-partially-constructed-object
branch
from
c6a7f06 to
ecb59ee
Compare
patkenneally
deleted the
fix/2110-prevent-inifinite-recursion-partially-constructed-object
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When setting a break point after the addition of a
pythonVariableLogger, that break point is never hit. The issue is infinite recursion on the__getattr__function in the python variable logger. Using__getattr__needs to be defensive about partially-initialized state. Usingself.__dict__["_variables"]avoids re-entering__getattr__and raises a clean KeyError/AttributeError when the attribute doesn't exist yet.Verification
Scenarios and tests that suffered from this error no longer do. CI runs.
Documentation
NA
Future work
None