Add configurable retries for the pin #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-correia
approved these changes
Dec 15, 2025
sergio-correia
left a comment
sergio-correia
left a comment
There was a problem hiding this comment.
Looks good overall, other than the minor nit I mentioned with the retry constant; It also likely needs to run cargo fmt and fix clippy warnings.
cli/src/main.rs
Outdated
|
|
||
| let executor = RealCommandExecutor; | ||
| let jwk = fetch_and_prepare_jwk(&config.servers, &config.path, initdata.clone(), &executor)?; | ||
| let num_retries = config.num_retries.as_ref().unwrap_or(&NumRetries::Finite(10)); |
There was a problem hiding this comment.
This 10 should be probably made into a constant; it is used again further on in decrypt().
Support for an optional field for setting the number of retries. This can be either a positive number or 'inifinity'. If no value is specify, then the pin tries 10 times all the servers. Signed-off-by: Alice Frosi <[email protected]>
alicefr
force-pushed
the
config-num-retries
branch
from
4eafbb5 to
fc7d8df
Compare
Contributor
Author
|
@sergio-correia thanks for the review. I run cargo fmt and replace the 10 with a constant. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for an optional field for setting the number of retries. This can be either a positive number or 'inifinity'. If no value is specify, then the pin tries 10 times all the servers.