fix(networking): catch real exceptions in get_external_ip fallback chain

[ArtificialXai]

Summary

Closes #3309.

Each provider in get_external_ip is wrapped in except ExternalIPNotFound, but none of the underlying calls (requests.get, ip_to_int, os.popen + readline, urllib.request.urlopen, json.loads, the Wikipedia header lookup) ever raise ExternalIPNotFound. As a result the first failing provider crashes the entire function instead of falling through to the next one — exactly the symptom reported in the issue (a requests.exceptions.ConnectionError propagates out when AWS is unreachable, rather than the curl fallback being attempted).

Fix

Replace each except ExternalIPNotFound: with a tuple of exceptions that the providers actually raise:

Exception	Where it originates
requests.exceptions.RequestException	requests.get(...) (AWS, Wikipedia)
netaddr.core.AddrFormatError	ip_to_int(...) with malformed input
OSError	os.popen(...) + readline() (ifconfig.me, ipinfo.io, dnsomatic)
urllib.error.URLError	urllib_request.urlopen(...) (ident.me)
ValueError	json.loads(...) parse failures, int(...) parse failures
KeyError	Wikipedia response missing X-Client-IP header
AssertionError	assert isinstance(ip_to_int(...), int) guard
ExternalIPNotFound	Kept for backward compatibility with any wrapper that raises it

The set is defined once at module scope as _IP_LOOKUP_EXCEPTIONS so the providers stay in sync.

Tests

Three new regression tests in tests/unit_tests/utils/test_networking.py:

• test_get_external_ip_aws_connection_error_falls_through_to_curl — AWS requests.get raises ConnectionError, curl fallback returns a valid IP, function returns that IP (was: raised ConnectionError).
• test_get_external_ip_malformed_ip_falls_through — AWS returns a non-IP string (triggers AddrFormatError in ip_to_int), curl fallback succeeds.
• test_get_external_ip_all_providers_exhausted_raises — every provider raises its real exception; function must raise ExternalIPNotFound (not leak the last underlying exception).

All 22 tests in tests/unit_tests/utils/test_networking.py pass locally.

Test plan

• pytest tests/unit_tests/utils/test_networking.py — all 22 pass
• CI run on PR

Notes

• The existing assert isinstance(ip_to_int(external_ip), int) line is tautological (ip_to_int either returns int or raises), but left unchanged to keep this PR narrow and focused on the reported bug.
• No behavior change when every provider succeeds — only the error-path taxonomy is corrected.

[basfroman]

Hey @ArtificialXai, pls read CONTRIBUTING.md to move forward with your pr.

[ArtificialXai]

Thanks for the pointer, @basfroman. Read CONTRIBUTING.md and updated the PR:

• Rebased onto staging and changed the PR base (was master).
• Rewrote the commit message to match the 6-rule style (subject <50 chars, body wrapped at 72, explains what and why).
• PR is still <50 files (2 files, 96/+6/-); the 3 regression tests in tests/unit_tests/utils/test_networking.py cover the real exception paths.

Ready for another look when you have a minute.

[thewhaleking]

Thanks for the pointer, @basfroman. Read CONTRIBUTING.md and updated the PR:

• Rebased onto staging and changed the PR base (was master).
• Rewrote the commit message to match the 6-rule style (subject <50 chars, body wrapped at 72, explains what and why).
• PR is still <50 files (2 files, 96/+6/-); the 3 regression tests in tests/unit_tests/utils/test_networking.py cover the real exception paths.

Ready for another look when you have a minute.

Your commit still isn't signed

[ArtificialXai]

Signed and re-pushed (d361f287).

[ArtificialXai]

Hey @basfroman, friendly ping — addressed all your feedback in the 2026-04-20 comment (rebased onto staging, commit message follows 6-rule style, tests cover the exceptions). Commit is now signed as of today (2026-04-24). Could you take another look when you get a moment? Thanks!