hoist get_required_fields out of to_headers#3323
Open
okradze wants to merge 1 commit intolatent-to:stagingfrom
Open
hoist get_required_fields out of to_headers#3323okradze wants to merge 1 commit intolatent-to:stagingfrom
okradze wants to merge 1 commit intolatent-to:stagingfrom
Conversation
okradze
force-pushed
the
fix/to-headers-perf
branch
from
7fb625e to
3b6680c
Compare
Contributor
|
Hey @okradze we require commits to be signed |
okradze
force-pushed
the
fix/to-headers-perf
branch
from
3b6680c to
9ef6bae
Compare
Contributor
You'll need to also upload your GPG key… |
Author
|
@thewhaleking Thanks, fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3322
Synapse.to_headers()callsself.get_required_fields()on every iteration of its field loop.get_required_fields()rebuildsmodel_json_schema()each time, which is expensive. For a synapse with N fields the schema is rebuilt N times per call, soto_headers()slows down as the synapse grows. Sinceto_headers()runs on every outgoing dendrite request, this adds latency to all subnet traffic.For a 20-field synapse with nested pydantic types: 68.77 ms/call → 2.51 ms/call (~27× speedup).
Changes
bittensor/core/synapse.py:required = self.get_required_fields()out of the field loop into_headers(). Reduces calls from N to 1; behavior unchanged.