Fix double count in runs page #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an issue where if you were in the runs page and you ran documents from somewhere else, the counter would count twice each run. This was because we had the sidebar and the runs page using the useActiveRunsCount hook, which would create two listeners of the WS event, and mutate twice the frontend state. This fix fixes that by creating a provider that uses this hook, and instantiating it in the layout for the children to use, and avoid duplicate counts.
| } | ||
|
|
||
| export function useActiveRunsCountContext() { | ||
| const context = useContext(ActiveRunsCountContext) |
Contributor
There was a problem hiding this comment.
Now need for custom hook for context in react.
const myThing = use(ActiveRunsCountContext) Takes care of checking the provider is provided
Contributor
Author
There was a problem hiding this comment.
top tyty for the KNOWLEDGE
andresgutgon
previously approved these changes
Nov 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where if you were in the runs page and you ran documents from somewhere else, the counter would count twice each run.
This was because we had the sidebar and the runs page using the useActiveRunsCount hook, which would create two listeners of the WS event, and mutate twice the frontend state.
This fix fixes that by creating a provider that uses this hook, and instantiating it in the layout for the children to use, and avoid duplicate counts.