Skip to content

fix(world): add missing virtual to World methods #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented May 9, 2025

I think skipping virtual only makes sense for worldVersion and storeVersion, otherwise it just makes overriding World impossible in some cases

Particularly I've been playing with eve's SOF today - since they can't override fallback the whole World code is copypasted rather than inherited

@dk1a dk1a requested a review from alvrs as a code owner May 9, 2025 17:37
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: 280e906

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dk1a dk1a requested a review from ludns as a code owner May 9, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant