fix: auto-rejoin voice on 4014/4015 websocket close - #253
Closed
connorjamessmith wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Discord forces a gateway reconnect (observed with DSharpPlus nightly), Lavalink can emit a
WebSocketClosedEventfor the voice websocket with close code4014(and sometimes4015). After this happens, Lavalink reports the player asconnected: falseand, today, Lavalink4NET only forwards the event to listeners without attempting recovery. In practice the bot can end up leaving voice and not reconnecting on its own.What This PR Changes
This PR adds an automatic recovery path inside
LavalinkPlayer:4014(Disconnected) and4015(Voice server crashed), Lavalink4NET re-asserts the existing voice connection by re-sending a Discord voice state update to the current channel.SelfDeaf/SelfMute.Behavior change:
EnableVoiceAutoReconnect = falseto preserve the previous behavior.New options:
LavalinkPlayerOptions.EnableVoiceAutoReconnect(default:true)LavalinkPlayerOptions.VoiceReconnectCooldown(default:10s)Tests
Adds unit tests covering:
Refs #200