Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kubectl apply with mesheryctl app onboard command #48

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/scripts/istio_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,19 @@
export MESH_NAME='Istio'
export SERVICE_MESH='ISTIO'

# Check if mesheryctl is present, else install it
if ! [ -x "$(command -v mesheryctl)" ]; then
echo 'mesheryctl is not installed. Installing mesheryctl client... Standby...' >&2
curl -L https://git.io/meshery | PLATFORM=kubernetes bash -
fi

curl -L https://istio.io/downloadIstio | ISTIO_VERSION=1.11.4 sh -
cd istio-1.11.4
export PATH=$PWD/bin:$PATH
istioctl install --set profile=demo -y
kubectl label namespace default istio-injection=enabled

kubectl apply -f samples/bookinfo/platform/kube/bookinfo.yaml
kubectl apply -f samples/bookinfo/networking/bookinfo-gateway.yaml
mesheryctl app onboard -f "samples/bookinfo/platform/kube/bookinfo.yaml"

# Wait for the application to be ready
sleep 100
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/scripts/linkerd_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,14 @@ linkerd check --pre
linkerd install | kubectl apply -f -
linkerd check

curl -fsL https://run.linkerd.io/emojivoto.yml | kubectl apply -f -
kubectl -n emojivoto port-forward svc/web-svc 8080:80 &> /dev/null &
kubectl get -n emojivoto deploy -o yaml | linkerd inject - | kubectl apply -f -
# Check if mesheryctl is present, else install it
if ! [ -x "$(command -v mesheryctl)" ]; then
echo 'mesheryctl is not installed. Installing mesheryctl client... Standby...' >&2
curl -L https://git.io/meshery | PLATFORM=kubernetes bash -
fi

curl -fsL https://run.linkerd.io/emojivoto.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curl command isn't putting the output in a file. For reference :- https://github.com/hershd23/meshery-smp-action/runs/6868074975?check_suite_focus=true#step:4:285

We can add it explicitly like shown

Suggested change
curl -fsL https://run.linkerd.io/emojivoto.yml
curl -fsL https://run.linkerd.io/emojivoto.yml --output emojivoto.yml

mesheryctl app onboard -f "./emojivoto.yml"

# Wait for the application to be ready
sleep 100
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/scripts/osm_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,13 @@ curl -L https://github.com/openservicemesh/osm/releases/download/${release}/osm-
--set=OpenServiceMesh.deployGrafana=true \
--set=OpenServiceMesh.deployJaeger=true

kubectl create namespace bookstore
./${system,,}-amd64/osm namespace add bookstore
kubectl apply -f https://raw.githubusercontent.com/openservicemesh/osm/release-v0.11/docs/example/manifests/apps/bookstore.yaml
# Check if mesheryctl is present, else install it
if ! [ -x "$(command -v mesheryctl)" ]; then
echo 'mesheryctl is not installed. Installing mesheryctl client... Standby...' >&2
curl -L https://git.io/meshery | PLATFORM=kubernetes bash -
fi

mesheryctl app onboard -f "samples/bookinfo/platform/kube/bookinfo.yaml"

sleep 100

Expand Down