generated from layer5io/layer5-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace kubectl apply with mesheryctl pattern apply
#56
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ac95f73
Lifted changes from alphaX86:enhance and changed Bookinfo URL + Wrote…
hershd23 5a8fd27
Merge branch 'master' of https://github.com/layer5io/meshery-smp-acti…
hershd23 29ddeb2
Added osm and changed Linkerd from onboard to apply
hershd23 a692777
Adding osm to configurable test
hershd23 e22ad7d
Changing osm bookstore URL
hershd23 f37f92a
Using app onboard for linkerd and osm
hershd23 1ae4d46
Downloading the application for OSM before onboarding
hershd23 f23c9b3
Replaced minikube install action
hershd23 eb4e7e5
Increased sleep time
hershd23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"meshery-provider":"None","token":""} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ on: | |
| options: | ||
| - istio | ||
| - linkerd | ||
| - osm | ||
| load_generator: | ||
| type: choice | ||
| required: false | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,64 +1,69 @@ | ||
| # This workflow runs performance benchmarks with Meshery based on the configuration provided | ||
| # This workflow needs to be triggered manually by providing the test configuration | ||
|
|
||
| name: Configurable Benchmark Test | ||
| on: | ||
| # for triggering the workflow, provide these inputs | ||
| workflow_dispatch: | ||
| inputs: | ||
| profile_name: | ||
| description: "performance profile to use" | ||
| required: false | ||
| profile_filename: | ||
| description: "test configuration file" | ||
| required: false | ||
| service_mesh: | ||
| type: choice | ||
| required: false | ||
| description: "service mesh being tested" | ||
| options: | ||
| - istio | ||
| - linkerd | ||
| load_generator: | ||
| type: choice | ||
| required: false | ||
| description: "load generator to run tests with" | ||
| options: | ||
| - fortio | ||
| - wrk2 | ||
| - nighthawk | ||
|
|
||
| jobs: | ||
| manual-test: | ||
| name: Configurable Benchmark Test | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event_name == 'workflow_dispatch' }} | ||
| steps: | ||
| - name: Setup Kubernetes | ||
| uses: manusa/[email protected] | ||
| with: | ||
| minikube version: 'v1.23.2' | ||
| kubernetes version: 'v1.23.2' | ||
| driver: docker | ||
| start args: "--v=5" | ||
|
|
||
| - name: Checkout Code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Install Service Mesh and Deploy Application | ||
| run: | | ||
| chmod +x .github/workflows/scripts/${{ github.event.inputs.service_mesh }}_deploy.sh | ||
| .github/workflows/scripts/${{ github.event.inputs.service_mesh }}_deploy.sh | ||
| shell: bash | ||
|
|
||
| - name: Run Benchmark Tests | ||
| uses: layer5io/meshery-smp-action@master | ||
| with: | ||
| provider_token: ${{ secrets.MESHERY_TOKEN }} | ||
| platform: docker | ||
| profile_name: ${{ github.event.inputs.profile_name }} | ||
| profile_filename: ${{ github.event.inputs.profile_filename }} | ||
| endpoint_url: ${{env.ENDPOINT_URL}} | ||
| service_mesh: ${{env.SERVICE_MESH}} | ||
| load_generator: ${{ github.event.inputs.load_generator }} | ||
| test_name: '${{ github.event.inputs.service_mesh }}-${{ github.event.inputs.load_generator }}-${{ github.event.inputs.profile_filename }}${{ github.event.inputs.profile_name }}' | ||
| # This workflow runs performance benchmarks with Meshery based on the configuration provided | ||
| # This workflow needs to be triggered manually by providing the test configuration | ||
|
|
||
| name: Configurable Benchmark Test | ||
| on: | ||
| # for triggering the workflow, provide these inputs | ||
| workflow_dispatch: | ||
| inputs: | ||
| profile_name: | ||
| description: "performance profile to use" | ||
| required: false | ||
| profile_filename: | ||
| description: "test configuration file" | ||
| required: false | ||
| service_mesh: | ||
| type: choice | ||
| required: false | ||
| description: "service mesh being tested" | ||
| options: | ||
| - istio | ||
| - linkerd | ||
| - osm | ||
| load_generator: | ||
| type: choice | ||
| required: false | ||
| description: "load generator to run tests with" | ||
| options: | ||
| - fortio | ||
| - wrk2 | ||
| - nighthawk | ||
|
|
||
| jobs: | ||
| manual-test: | ||
| name: Configurable Benchmark Test | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event_name == 'workflow_dispatch' }} | ||
| steps: | ||
| - name: Setup Kubernetes | ||
| uses: medyagh/[email protected] | ||
| with: | ||
| minikube version: v1.23.2 | ||
| kubernetes version: v1.23.2 | ||
| driver: docker | ||
| apus: 4 | ||
| memory: 5192 | ||
|
|
||
| - name: Checkout Code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Install Service Mesh and Deploy Application | ||
| run: | | ||
| chmod +x .github/workflows/scripts/${{ github.event.inputs.service_mesh }}_deploy.sh | ||
| .github/workflows/scripts/${{ github.event.inputs.service_mesh }}_deploy.sh | ||
| shell: bash | ||
|
|
||
| - name: Initiate tmate session | ||
| uses: mxschmitt/action-tmate@v3 | ||
|
|
||
| - name: Run Benchmark Tests | ||
| uses: layer5io/meshery-smp-action@master | ||
| with: | ||
| provider_token: ${{ secrets.MESHERY_TOKEN }} | ||
| platform: docker | ||
| profile_name: ${{ github.event.inputs.profile_name }} | ||
| profile_filename: ${{ github.event.inputs.profile_filename }} | ||
| endpoint_url: ${{env.ENDPOINT_URL}} | ||
| service_mesh: ${{env.SERVICE_MESH}} | ||
| load_generator: ${{ github.event.inputs.load_generator }} | ||
| test_name: '${{ github.event.inputs.service_mesh }}-${{ github.event.inputs.load_generator }}-${{ github.event.inputs.profile_filename }}${{ github.event.inputs.profile_name }}' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hershd23 Can we still use manusa/[email protected] and use
start args: "--cpu 4 --memory 5192"to set the cpu and memory? Because it's better to reduce unnecessary changes in this PR. I suggested it in #48, can you try to prove that everything when usingmanusa/actions-setup-minikube?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. @hershd23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/hershd23/meshery-smp-action/runs/7053416986?check_suite_focus=true
Works fine, I had to increase the sleep timer for istio though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!