fix: security audit — admin auth bypass, credential logging, path traversal, weak nonce, unsafe CSP#3134
Open
Vucius wants to merge 7 commits into
Open
fix: security audit — admin auth bypass, credential logging, path traversal, weak nonce, unsafe CSP#3134Vucius wants to merge 7 commits into
Vucius wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes five security issues found during static and logic review:
Offunsafe-evalIt also updates GitHub Actions so upstream PR validation can run without private signing secrets and without blocking on existing Clippy warnings.
Most Rust files in the diff were touched by
cargo fmtso the upstreamcargo fmt -- --checkjob passes. The security-relevant logic changes are concentrated in:src-tauri/src/proxy/middleware/auth.rssrc-tauri/src/lib.rssrc-tauri/src/commands/mod.rssrc-tauri/src/utils/crypto.rssrc-tauri/tauri.conf.json.github/workflows/*.ymlChanges
1. Admin interface no longer bypasses authentication when
auth_mode=OffFile:
src-tauri/src/proxy/middleware/auth.rsThe admin branch of the shared auth middleware previously honored
ProxyAuthMode::Off, allowing/api/*management endpoints to bypass authentication.The
force_strict=truepath now always requires admin authentication except for health check endpoints. Admin password is checked first, falling back toapi_keywhen no dedicated admin password is configured.2. Headless mode no longer logs plaintext credentials
File:
src-tauri/src/lib.rsHeadless startup logs previously printed
config.proxy.api_keyandconfig.proxy.admin_passworddirectly.This PR adds
credential_state(value)and logs only whether credentials are set: