-
-
Notifications
You must be signed in to change notification settings - Fork 271
Bump LDC-LLVM to v21.1.5 #4990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kinke
wants to merge
10
commits into
ldc-developers:master
Choose a base branch
from
kinke:llvm_21
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,074
−55
Draft
Bump LDC-LLVM to v21.1.5 #4990
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
25916d8
ldc.intrinsics: Prepare for LLVM 21 final
kinke 27fcd01
Bump LDC-LLVM to v21.1.5
kinke 30e68f0
[add vendored LLVM 21 tools and utils]
kinke 4de521a
GC2Stack: Fix logic regression for LLVM 21+
kinke 64edb73
[lit-test: Adapt to cosmetic asm offset changes with LLVM 21]
kinke fe80b5c
[adapt android-llvm-config.in to LLVM 21]
kinke 158a8f0
lit-tests: Adapt codegen/align.d to LLVM 21 IR changes
kinke 154e08d
[macOS: Switch to clang 21 for x86_64 job too, incl. image bump to ma…
kinke 244a20f
CI: Add vanilla-LLVM 20 job
kinke 48721ad
CMake: Prefer LLVM 21
kinke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,12 +21,12 @@ Outer passAndReturnOuterByVal(Outer arg) { return arg; } | |
| // CHECK-SAME: ptr {{noalias sret.*|inreg noalias}} align 32 %.sret_arg | ||
| /* How the arg is passed by value is ABI-specific, but the pointer must be aligned. | ||
| * When the argument is passed as a byte array and copied into a stack alloc, that stack alloca must be aligned. */ | ||
| // CHECK: {{(align 32 %arg|%arg = alloca %align.Outer, align 32)}} | ||
| // CHECK: {{(align 32 %arg|%arg = alloca %align.Outer, align 32|call void @llvm.memcpy.* %.sret_arg,.* %arg)}} | ||
|
|
||
| Inner passAndReturnInnerByVal(Inner arg) { return arg; } | ||
| // CHECK: define{{.*}} void @{{.*}}_D5align23passAndReturnInnerByValFSQBh5InnerZQl | ||
| // CHECK-SAME: ptr {{noalias sret.*|inreg noalias}} align 32 %.sret_arg | ||
| // CHECK: {{(align 32 %arg|%arg = alloca %align.Inner, align 32)}} | ||
| // CHECK: {{(align 32 %arg|%arg = alloca %align.Inner, align 32|call void @llvm.memcpy.* %.sret_arg,.* %arg)}} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
|
||
| void main() { | ||
| Outer outer; | ||
|
|
@@ -61,11 +61,11 @@ void main() { | |
| // CHECK: call{{.*}} void @{{.*}}_D5align23passAndReturnOuterByValFSQBh5OuterZQl | ||
| // CHECK-SAME: ptr {{noalias sret.*|inreg noalias}} align 32 %.sret_tmp | ||
| // The argument is either passed by aligned (optimizer hint) pointer or as an array of i32/64 and copied into an aligned stack slot inside the callee. | ||
| // CHECK-SAME: {{(align 32 %|\[[0-9]+ x i..\])}} | ||
| // CHECK-SAME: {{(align 32 |\[[0-9]+ x i..\])}} | ||
|
|
||
| inner = passAndReturnInnerByVal(inner); | ||
| // CHECK: call{{.*}} void @{{.*}}_D5align23passAndReturnInnerByValFSQBh5InnerZQl | ||
| // CHECK-SAME: ptr {{noalias sret.*|inreg noalias}} align 32 %.sret_tmp | ||
| // The argument is either passed by aligned (optimizer hint) pointer or as an array of i32/64 and copied into an aligned stack slot inside the callee. | ||
| // CHECK-SAME: {{(align 32 %|\[[0-9]+ x i..\])}} | ||
| // CHECK-SAME: {{(align 32 |\[[0-9]+ x i..\])}} | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5004 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the
memcpygot the correct alignments (instead of 1), we could check them in the regex directly. But currently: