[LLVM21] codegen/align.d these are now memcpy'd and captures(none)
#5004
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilsonator
commented
Oct 27, 2025
| // CHECK-SAME: ptr {{noalias sret.*|inreg noalias}} align 32 %.sret_tmp | ||
| // The argument is either passed by aligned (optimizer hint) pointer or as an array of i32/64 and copied into an aligned stack slot inside the callee. | ||
| // CHECK-SAME: {{(align 32 %|\[[0-9]+ x i..\])}} | ||
| // CHECK-SAME: {{(align 32 .*%|\[[0-9]+ x i..\])}} |
There was a problem hiding this comment.
captures(none) appears here in llvm21
There was a problem hiding this comment.
Is there any reason not to use {{( captures\(none\))?}} here?
There was a problem hiding this comment.
Because I suck at regex
| // CHECK-SAME: ptr {{noalias sret.*|inreg noalias}} align 32 %.sret_tmp | ||
| // The argument is either passed by aligned (optimizer hint) pointer or as an array of i32/64 and copied into an aligned stack slot inside the callee. | ||
| // CHECK-SAME: {{(align 32 %|\[[0-9]+ x i..\])}} | ||
| // CHECK-SAME: {{(align 32 .*%|\[[0-9]+ x i..\])}} |
| /* How the arg is passed by value is ABI-specific, but the pointer must be aligned. | ||
| * When the argument is passed as a byte array and copied into a stack alloc, that stack alloca must be aligned. */ | ||
| // CHECK: {{(align 32 %arg|%arg = alloca %align.Outer, align 32)}} | ||
| // CHECK: {{(align 32 %arg|%arg = alloca %align.Outer, align 32|call void @llvm.memcpy)}} |
There was a problem hiding this comment.
these are now memcpy'd directly instead of being alloca'd. I don't see an easy way to check the alignment here
There was a problem hiding this comment.
maybe force the stack alloc by modifying the parameter in the function body (i.e. add some code to the test function, to disable the direct memcpy optimization)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.