Skip to content

🛡️ Sentinel: [MEDIUM] Fix stack trace exposure in error boundary #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ldsgroups225 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🛡️ Sentinel: [MEDIUM] Fix stack trace exposure in error boundary #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/core/src/components/default-catch-boundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function DefaultCatchBoundary({ error }: ErrorComponentProps) {

// Format error details for display
const errorMessage = error?.message || 'An unexpected error occurred'
const errorStack = error?.stack || ''
const errorStack = import.meta.env.DEV ? (error?.stack || '') : ''
const hasStack = errorStack.length > 0

const handleReportError = () => {
Expand Down
2 changes: 1 addition & 1 deletion apps/school/src/components/default-catch-boundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function DefaultCatchBoundary({ error, reset }: ErrorComponentProps) {
const [copied, setCopied] = useState(false)

const errorMessage = error?.message || t.common.unexpectedError()
const errorStack = error?.stack || ''
const errorStack = import.meta.env.DEV ? (error?.stack || '') : ''
const hasStack = errorStack.length > 0

const handleCopyError = async () => {
Expand Down
5 changes: 5 additions & 0 deletions pr_desc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
🚨 Severity: MEDIUM
💡 Vulnerability: The application was exposing full error stack traces in `DefaultCatchBoundary` to the user interface in production.
🎯 Impact: This could potentially leak internal application paths, code structure, or dependencies to end-users or attackers during an unexpected error.
🔧 Fix: Used `import.meta.env.DEV` to check if we are in development mode and only populated the `errorStack` constant when `DEV` is true.
✅ Verification: Verify that the error boundary still catches errors correctly and the UI correctly doesn't render stack trace sections when `NODE_ENV` / `import.meta.env.DEV` resolves to false.
Loading