Skip to content

🎨 Palette: Add aria-label to notification button #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ldsgroups225 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

🎨 Palette: Add aria-label to notification button #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/school/src/components/layout/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function Header() {
{/* Notifications */}
<button
type="button"
aria-label={t.common.notifications()}
className={cn(
`
relative inline-flex h-9 w-9 items-center justify-center
Expand All @@ -45,7 +46,6 @@ export function Header() {
)}
>
<IconBell className="h-5 w-5" />
<span className="sr-only">{t.common.notifications()}</span>
{/* Notification badge */}
<span className="absolute top-1 right-1 flex h-2 w-2">
<span className="
Expand Down
4 changes: 4 additions & 0 deletions pr_desc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
💡 What: Added an `aria-label` to the icon-only notification button in the app header and removed the visually hidden `sr-only` span.
🎯 Why: Using `aria-label` directly on the `<button>` element is a cleaner, more robust pattern for icon-only buttons than relying on inner visually hidden spans, ensuring consistent screen reader announcements.
📸 Before/After: Visuals remain unchanged (internal HTML structure update only).
♿ Accessibility: Improves semantic HTML structure and screen reader support for the primary navigation header's notification action.
Loading