Skip to content

🎨 Palette: Add loading spinner to conduct record form submit button#221

Open
ldsgroups225 wants to merge 1 commit intomasterfrom
fix/ux-loading-spinner-conduct-7198014369727887564
Open

🎨 Palette: Add loading spinner to conduct record form submit button#221
ldsgroups225 wants to merge 1 commit intomasterfrom
fix/ux-loading-spinner-conduct-7198014369727887564

Conversation

@ldsgroups225
Copy link
Copy Markdown
Owner

@ldsgroups225 ldsgroups225 commented Mar 30, 2026

💡 What: Added a loading spinner (IconLoader2 from @tabler/icons-react with animate-spin utility) to the Conduct Record Form's submit button while the form is saving (submitDisabled is true).

🎯 Why: The user problem it solves is providing clear, immediate visual feedback that a background operation (saving the conduct record) is in progress, preventing confusion or double-submissions when network requests take time.

📸 Before/After:
Before: The button text simply changed to "Saving..." without visual indication of activity.
After: A spinning loading icon appears next to the "Saving..." text.

♿ Accessibility: The button is already appropriately disabled via the disabled={submitDisabled} attribute, which is correctly conveyed to screen readers. Adding the visual spinner ensures parity for visual users.


PR created automatically by Jules for task 7198014369727887564 started by @ldsgroups225

Summary by CodeRabbit

  • New Features
    • Added visual loading indicator to the form submit button, displaying a spinning animation during submission to provide user feedback that the action is processing.

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7eb22e23-3d4e-4e4b-af6d-f65db3dd6f5e

📥 Commits

Reviewing files that changed from the base of the PR and between 7e37ef8 and 7f623f3.

📒 Files selected for processing (1)
  • apps/school/src/components/conduct/conduct-record-form-inner.tsx

📝 Walkthrough

Walkthrough

Updated the submit button in the conduct record form to display a spinning loader icon when submission is disabled, with CSS flex alignment adjustments to properly center the icon next to the button label.

Changes

Cohort / File(s) Summary
Submit Button Loading Indicator
apps/school/src/components/conduct/conduct-record-form-inner.tsx
Added conditional rendering of IconLoader2 spinner icon inside submit button when submitDisabled is true. Updated button classes to use flex and items-center for proper icon-label alignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A button spins with eager pace,
With loader dancing in its space,
Flex and center, aligned just right,
When saving work becomes a sight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding a loading spinner to the conduct record form submit button, which aligns with the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ux-loading-spinner-conduct-7198014369727887564

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant