Skip to content

Make gates non-waterloggable, even in the presence of addons #10785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: version/main
Choose a base branch
from

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Apr 12, 2025

Closes discord report

Changes proposed in this pull request

  • Makes gates not waterloggable by default. (It was never properly implemented to begin with, and didn't actually work.)
  • For compat with Dramatic Doors, if some other mod makes them waterloggable anyway, resists this change.
    • Blueprints scanned in older versions of Minecolonies were likely saved with invisibly-waterlogged gates (that became actually waterlogged when that mod is installed). Blueprint previews will still show this, but on actual placement the waterlogged state will go away on its own. For best results, rescan any gates in a version from after this patch.
      • I have not tested if this blockstate change will annoy the builder.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (should port)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants