Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlights not clearing due to incorrect keys #10786

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Fix highlights not clearing due to incorrect keys #10786

merged 1 commit into from
Apr 13, 2025

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Apr 12, 2025

Changes proposed in this pull request

  • Fixes incorrect behaviour of timed block highlights due to inappropriate use of unique keys.
    • In particular, this fixes the red error highlights from supply camp/ship placement errors so that they correctly disappear immediately when you either make another placement attempt or click the red X button.
    • (Untested) This will also fix the previous warehouse search indicators remaining when performing another search.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (should port)

@someaddons someaddons merged commit 4e1e12b into version/main Apr 13, 2025
5 checks passed
@someaddons someaddons deleted the fix/highlights branch April 13, 2025 20:17
someaddons pushed a commit that referenced this pull request Apr 13, 2025
@uecasm @someaddons
Fix highlights not clearing due to incorrect keys (#10786)
151abdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raycoms Raycoms Raycoms approved these changes

@someaddons someaddons someaddons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uecasm @Raycoms @someaddons