compiler:remove unneccessary clone in final code gen #165
Open
Timosdev99 wants to merge 1 commit intoleanEthereum:mainfrom
Open
compiler:remove unneccessary clone in final code gen #165Timosdev99 wants to merge 1 commit intoleanEthereum:mainfrom
Timosdev99 wants to merge 1 commit intoleanEthereum:mainfrom
Conversation
Collaborator
|
Hi, thanks for the PR. Since the compilation performance is not currently an issue (and overall it's never a bottleneck since we need need to compile once, and then it does not impact the proving performance of the snarks), I would suggest we keep the compilation pipeline as simple as possible (even though it's already too much complex..), in particular Cloning is not an issue, and I think it's slightly simpler than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr unnecessary cloning of intermediate byte code blocks and per instruction cloning during final code gen. the compiler now moves byte code block by value and processes instruction by reference
intermediate_bytecode.bytecodeintocode_blocksinstead of cloningVec<IntermediateInstruction>compile_blockandcodegen_jumpto use burrowedIntermediateInstruction/IntermediateValuerather than clone each instructionthe previous implementation duplicate the entire intermediate program and cloned every instruction inside a hot loop, causing unnecessary heap allocation