Conversation
unnawut
left a comment
unnawut
left a comment
There was a problem hiding this comment.
Made these annotations when I submitted this PR but forgot to submit
docs/client/networking.md
Outdated
|
|
||
| Topics are plain UTF-8 strings and are encoded on the wire as determined by | ||
| protobuf (gossipsub messages are enveloped in protobuf messages). Topic strings | ||
| have form: `/leanconsensus/devnet0/Name/Encoding`. This defines both the type of |
There was a problem hiding this comment.
Originally /eth2/ForkDigestValue/Name/Encoding in the beacon specs
There was a problem hiding this comment.
we should probably retain ForkDigestValue here instead of devnet0
There was a problem hiding this comment.
Related convo at #8 (comment) so what's concluded there will be updated here.
docs/client/networking.md
Outdated
|
|
||
| - `ssz_snappy` - All objects are SSZ-encoded and then compressed with | ||
| [Snappy](https://github.com/google/snappy) block compression. Example: The | ||
| lean block topic string is `/leanconsensus/devnet0/lean_block/ssz_snappy`, |
There was a problem hiding this comment.
Originally /eth2/446a7232/beacon_aggregate_and_proof/ssz_snappy
docs/client/networking.md
Outdated
| With: | ||
|
|
||
| - `ProtocolPrefix` - messages are grouped into families identified by a shared | ||
| libp2p protocol name prefix. In this case, we use `/leanconsensus/req`. |
There was a problem hiding this comment.
Originally /eth2/beacon_chain/req
docs/client/networking.md
Outdated
|
|
||
| ##### LeanBlocksByRoot v1 | ||
|
|
||
| **Protocol ID:** `/leanconsensus/req/lean_blocks_by_root/1/` |
There was a problem hiding this comment.
Originally /eth2/beacon_chain/req/beacon_blocks_by_root/1/
Co-authored-by: Jun Song <87601811+syjn99@users.noreply.github.com>
Co-authored-by: g11tech <develop@g11tech.io>
|
|
||
| ``` | ||
| ( | ||
| List[Root, MAX_REQUEST_BLOCKS] |
There was a problem hiding this comment.
Should we define MAX_REQUEST_BLOCKS here?
There was a problem hiding this comment.
Copied over 2*10 (= 1024) from beacon specs: d19d93
This is 1024 * 4 / 60 = 68 minutes worth of block under 4s block time
| ```python | ||
| class SignedVote(Container): | ||
| data: Vote, | ||
| signature: Bytes32, |
There was a problem hiding this comment.
To update to exact size (~3KiB) based on researchers' input
|
Merging now as the overall suggestions are addressed. We can continue to make specific changes in separate PRs. Some few last changes: |
8 participants
🗒️ Description
Introducing the 1st draft of pqdevnet-0 client specs.
This PR contains only the markdown specs. The python specs is paused for clearer direction before resuming.
Closes leanEthereum/pm#27
🔗 Related Issues or PRs
Combined #5 and #7.
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx --with=tox-uv tox