Add Custodial Wallet Persistence and KMS References#111
Open
heymide wants to merge 2 commits into
Open
Conversation
Author
|
Done, Close: #111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
Here's a summary of what was implemented:
Schema Changes
schema.prisma: Added Wallet and ManagedKey models with:
Wallet: userId (unique), publicKey (unique), network, custody, status, managedKeyId (unique), timestamps
ManagedKey: provider, keyId, keyVersion, opaque envelope (no plaintext secrets)
User.wallet relation added
Migration
migration.sql: Creates both tables with unique constraints on userId, publicKey, and managedKeyId, plus a composite index on (userId, status)
Types & Transitions
wallet.types.ts: Defines WalletStatus (PROVISIONING, ACTIVE, FAILED, EXPORT, MIGRATED, DISABLED), WalletNetwork, WalletCustody enums, transition guard map, isValidWalletTransition(), DTOs, and redactWallet() which nullifies managedKeyId to prevent KMS references leaking into responses
KMS Interface
kms.interface.ts: KMS interface with createKey, getKeyHandle, rotateKey, scheduleDestruction — all return opaque handles only
fake-kms.ts: In-memory FakeKMS implementation for dev/test
Tests (39 passing)
wallet-transitions.test.ts — 21 tests covering all valid/invalid transitions including terminal DISABLED state
wallet-redaction.test.ts — 5 tests verifying managedKeyId is stripped and no secrets leak
kms.test.ts — 13 tests covering full KMS lifecycle and verifying handles never expose plaintext secrets