Fix: Breadcrumb Wrapping & Select All Box Overlap in Arabic Interface #4920
Conversation
- Added RTL support for breadcrumbs - Fixed text overflow handling - Improved multiselect component layout - Added proper spacing for select all box Resolves learningequality#4829
There was a problem hiding this comment.
Hi @Annu881, thank you for your contributions.
As I noted in the issue when it was assigned to you, this is a troublesome issue to tackle, because the code is very finicky. The manner of the fix will likely be a change to the existing code. This PR only adds to the code, and adds code which at a glance does not seem like it will maintain existing behavior and fix the issue. Would you like to tackle another issue?
contentcuration/contentcuration/frontend/settings/pages/Storage/RequestForm.vue
Outdated
Show resolved
Hide resolved
|
Hi @Annu881, I previewed this change and I can confirm it helps in some cases. Thanks for giving it a try. I won't merge though because some techniques, such as applying another ellipsis on top of the existing ones, are not suitable - this would only patch the problem rather than addressing the roots/ I think it will be best to reframe the original issue as something to be investigated first and then next steps discussed. |
Resolves #4829
Summary
This PR introduces the following improvements:
Added RTL (Right-to-Left) support for breadcrumbs
Fixed text overflow handling to prevent UI breakage
Improved multi-select component layout for better usability
Added proper spacing for the "Select All" box to ensure better alignment
References
…
Reviewer guidance
…