Skip to content

Conversation

@ozer550
Copy link
Member

@ozer550 ozer550 commented Nov 13, 2025

Summary

  • Cleared the trash Vuex cache and reset pagination flags, so reopening the modal always starts from page one.

References

Reviewer guidance

  • Delete a large number of resources and open the channel's Trash page
  • Clicking several times on 'Show more' works now with proper pagination.
  • Close the modal and reopen it
  • It still works with pagination getting reset.

@ozer550 ozer550 changed the base branch from unstable to hotfixes November 13, 2025 06:27
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing that newly deleted nodes end up at the end of the trash list, when they should be at the top. I do not observe this on production, so it feels like it must be related to these changes.

After deleting Sparkfun-RPi5, it appeared at the bottom. A clue to the issue might be the modified time, for when it was deleted, because that isn't correct. After refreshing the page, the order is correct.

Before Refresh After Refresh
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hotfixes - Channel trash - Closing the Trash modal doesn't reset the pagination state

2 participants