[Remove Vuetify from Studio] Convert Sign In page unit tests to Vue Testing Library #5553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d next-redirect & payload checks
2 tasks
2 tasks
MisRob
changed the title
Member
|
Hi @Gopisokk, thanks. We will assign a reviewer. The tests are failing - can you check on it? |
MisRob
reviewed
Nov 18, 2025
| [wrapper, login] = await makeWrapper(); | ||
| await wrapper.vm.$nextTick(); | ||
| loginToProceed = wrapper.findAllComponents('[data-test="loginToProceed"]').at(0); | ||
| describe('AccountsMain (VTL)', () => { |
Member
There was a problem hiding this comment.
Suggested change
| describe('AccountsMain (VTL)', () => { | |
| describe('AccountsMain', () => { |
No need to mention what library is used in test descriptions.
MisRob
reviewed
Nov 18, 2025
| await wrapper.vm.$nextTick(); | ||
| loginToProceed = wrapper.findAllComponents('[data-test="loginToProceed"]').at(0); | ||
| describe('AccountsMain (VTL)', () => { | ||
| test('renders sign-in form', () => { |
Member
There was a problem hiding this comment.
Convention in this codebase is it rather than test.
Author
|
Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5534
Summary
Refactors
accounts/pages/__tests__/accountsMain.spec.jsto Vue Testing Library (sub-issue of #5060).What changed
render,screen,userEvent, and arenderComponenthelper.getByLabelText/getByRole) with a singledata-test="loginToProceed"hook.AccountNotActivated.loginmock action; no deprecatedmethodsstubbing.window.location(assign/replace) to avoid jsdom navigation errors.setImmediatedependency.?next=banner + redirect, generic failure (no navigation), 405 →AccountNotActivated, and exact payload (email/username + password).nextis asserted in the redirect test viawindow.location.assign, not as part of the action payload (matches current behavior).Why (Testing Library principles)
Asserts user-visible behavior and dispatched actions rather than component internals, reducing brittleness and easing refactors (e.g., removing Vuetify).
Acceptance & guide alignment
renderComponentwith overridable router/store.Risk / Impact
How to verify locally
pnpm install
pnpm run test -- accounts/pages/tests/accountsMain.spec.js
Expect: 7 passed
Security & privacy: N/A (tests only; no user data)
Internationalization: N/A (tests only; one non-user-facing test id)
LTR/RTL: N/A (no UI change)
Deployment/migrations: N/A
Linked issue: Sub-issue of #5060