Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Implement basic MSTS cabview parser #167

Closed
wants to merge 1 commit into from
Closed

Conversation

leezer3
Copy link
Owner

@leezer3 leezer3 commented Jul 25, 2017

This branch implements an incomplete MSTS cabview parser.

Supported:

  • Power & brake handles. (Basic config only- Both engine and loco brake levers work together)
  • Ammeter (Uses the BVE power related bodge, not 'real')
  • Brake pipe/ brake cylinder gauges

TODO:

  • Tweak the current parser, so that subject transform and element config form part of the base loader, rather than being duplicated in each file.
  • Add appropriate error message if the power/ brake notches in the CVF don't match that in the train.

@leezer3
Copy link
Owner Author

leezer3 commented Jul 25, 2017

Oops, makefile not updated, hence why Travis is falling over.

Will fix tomorrow.

Uses the new block format parser
@leezer3
Copy link
Owner Author

leezer3 commented May 17, 2018

Redone in the block reader style.
c3d05af needed: Quote-enclosed strings seem to be common in CVF files, whereas shape files are 99% binary.

Flaws at present (Incomplete list):

  • No loco brake; New: Add independant loco brake #241 , this is currently hooked to the main brake.
  • Need to implement the MSTS ammeter (Requires parsing the .eng files)
  • No warnings etc. if the number of notches don't match (Again, parse the .eng files)
  • No AWS/ TPWS/ US signalling: It'd actually be useful to port this from BVEC_ATS to the inbuilt systems for BVE trains on Linux. Could also include BVEC_ATS and use it to run the plugin for MSTS?
  • No vaccum brake support, just uses the air brake values.
  • No headlight support. Key config is enabled for plugins, so we really want a global variable (Accessible through runtime). This will also be helpful in later external animations.
  • Need to check the DirIncrease and Direction values for exact behaviour.
  • No support for textual font stuff.
  • Style value not supported- Need to also implement sprung controls into the main sim.

@leezer3 leezer3 force-pushed the master branch 4 times, most recently from b734a52 to 3f5ad6a Compare April 20, 2019 11:53
@leezer3 leezer3 force-pushed the master branch 5 times, most recently from bad6395 to 438f090 Compare November 20, 2020 11:41
@leezer3 leezer3 added this to the 1.9.0 milestone Jun 3, 2021
@leezer3
Copy link
Owner Author

leezer3 commented Jun 3, 2021

Now train plugins are available, this needs to be moved into it's own plugin, and a parser implemented for the consist files and the ENG files.

All of these follow the same basic principle / token block method, so it's do-able with relatively little code, but check our missing features list above?!

@leezer3
Copy link
Owner Author

leezer3 commented Aug 9, 2021

Closing this in favour of #684

@leezer3 leezer3 closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant