Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Improve handling of excessively large StructureIdx values #186

Merged
merged 3 commits into from
Sep 7, 2017

Conversation

leezer3
Copy link
Owner

@leezer3 leezer3 commented Sep 6, 2017

Closes #185

Needs some more testing to make sure nothing has broken.

Specifically:

  • Test what happens when an object indices is declared twice. ==> Broken, see below.
  • Double-check routes using .Crack and the other deformable object types.
  • Do we port to Route Viewer? New: Basic route viewer mode for the main program #165 may negate the need for this, but not sure how far away that is.

@leezer3
Copy link
Owner Author

leezer3 commented Sep 6, 2017

Fiddle, some of the Travis builds are failing because using as an inline out isn't actually supported until C# 7.0, despite the fact that this is just a syntatic little push....

Will fix that, and probably port to Route Viewer later.

@leezer3
Copy link
Owner Author

leezer3 commented Sep 6, 2017

Hmm.
Object indicies declared twice now throw an exception (Object containing the same key has already been added)

This is not logged anywhere either, which isn't good, and wasn't before this was started either.
Current behaviour is to always overwrite with the new object.

TODO:

  • Implement our own dictionary class, allowing us to override the Add method (Probably requires the least amount of work ( https://stackoverflow.com/questions/6250706/override-dictionary-add )
  • Log the fact that an object index has been used twice- This may increase error counts slightly on some routes, but it's worth it.
  • Check BVE2 & BVE4 behaviour on this front. BVE2 / BVE4 both overwrite the object with that most recently loaded & generate no errors.

@leezer3 leezer3 merged commit 32fb937 into master Sep 7, 2017
@leezer3 leezer3 deleted the StructureIdx branch September 26, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant