-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add power supply types, voltages etc. to CSV / RW routes #501
base: master
Are you sure you want to change the base?
Conversation
Secondary thought- Would we be better with just adding a pantograph to all cars? |
More thoughts:Do the pantograph and beacon follower need to be moved into a nice class thingy? Further:The BeaconFollower is always positioned in the center of the car. Moving this will break legacy compatability, but in a prototypical unit the reciever for track based transducers (AWS, TPWS etc.) would be mounted on the leading bogie at each end of a unit. |
Simplified by adding the pantograph to all cars (train.dat) as per the thoughts above. For adding to train.xml, something like this will be wanted I think: <Pantograph>
<Fitted>true</Fitted>
<Location>0.5</Location>
</Pantograph>
Probably too complicated to allow a pantograph to only recieve one type of current, this logic should be handled in the train itself. |
Last commit isn't strictly related to this, but will be doing work in there shortly to add the voltages to the API data provided & this was another oversized lump file which needed splitting into the component classes. |
Basic implementation is complete for this. Doing this has the minor issue of adding another overload to the vehiclestatus constructor, but this is inevitable with the current C# way of doing things. |
bad6395
to
438f090
Compare
5f23a6d
to
a53fd14
Compare
Manually brought this branch up-to date with the current master. Needs testing, not sure what if anything is now broken. |
This PR adds power supply voltages and types etc. to the CSV route parser.
Currently, these are handled by a set of non-standard beacons and the associated runtime plugin.
New Routefile Commands:
n.b. These commands apply from the start of a block.
Track.PowerSupply RailIndex, PowerSupplyType, VoltageType, Voltage, Amperage, ContactHeight
Starts a new power supply.
Default values are as follows:
OHLE- 25,000v, AC, 1,000A, 5.3m contact height
Third rail- 750v, DC, 3,000A, 0m contact height
Fourth rail- 750v, DC, 3,000A, 0m contact height
Track.PowerSupplyEnd RailIndex, PowerSupplyType
Ends the given power supply.
TODO:
BEFORE MERGING
Add current collector track followers to trains.Add control over where the current collector is placed.Add variables to animated objects.- TEST IMPLEMENTATIONAllow pantographs to be set via XML.THOUGHTS AND IDEAS