New: Implement sprung handle types #755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively common feature of prototype power / brake handles is a spring feature.
This gradually returns the handle to a 'default' position after a set period of time.
This PR implements this, along with some missing XML plumbing for setting the number of power / brake notches.
Significant Changes:
TODO:
Future Design Issues to Consider:
Really, we ought to have a per-car handle. If in the future, decoupling or changing the physical driving cab is implemented, this would allow the 'new' driving cab to have correct handle types etc.
This could possibly be done relatively easily via changing the current handle location to be a reference to the actual handle within the current driver car.
However, this could equally create a total and utter mess with existing content, and anything not specifically designed for this.
Possibly could do something like aliasing DriverCar to the inital driver car, and using CurrentDriverCar as the reccomended variable going forward, but that's just got a different set of messes to contend with.
Still a WIP, and not added to the documentation yet.
Loosely related to #684 as MSTS allows this handle type.