Skip to content

Add Chud Codex pet (original character, v2) - #113

Merged
legeling merged 3 commits into
legeling:mainfrom
Jorge-Cuevas90003:add-chud-codex
Aug 11, 2026
Merged

Add Chud Codex pet (original character, v2)#113
legeling merged 3 commits into
legeling:mainfrom
Jorge-Cuevas90003:add-chud-codex

Conversation

@Jorge-Cuevas90003

@Jorge-Cuevas90003 Jorge-Cuevas90003 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pet: Chud Codex (chud-codex--jorge-cuevas90003), a new original character. Category: Original Characters. No related request or duplicate.
  • v2 atlas 1536x2288, 8x11, 192x208 frames, WebP lossless, CC BY-NC 4.0. AI-assisted from my own concept; no third-party assets.
  • Also adds the required install-manifest.json record (10 added lines, existing formatting untouched).

One deliberate deviation: rows 3 and 4 are swapped versus the documented v2 order — row 3 is jumping, row 4 is waving. The desktop app hardcodes hover to the jumping animation, so this makes the pet wave on hover instead of jump. Happy to ship the standard order instead if you prefer.

On CI: validate:pr and lint already fail on a clean main (189 stale manifest errors, 426 Prettier files). My package adds zero errors of its own.

Visual evidence

Contact sheet below.

Checklist

  • One pet only
  • Checked gallery and open issues for the same character
  • canonical_key correct; not a byte-identical copy
  • Folder pet-slug--author-slug, contains only the 3 required files
  • pet.json id matches the folder name
  • v2: 1536x2288 atlas, spriteVersionNumber: 2, all 16 look directions included and reviewed
  • submission.json filled in; authorship and usage terms clear
  • Contact sheet available
  • Identity, scale, baseline and props consistent across every frame (verified numerically: visor width and figure height measured per frame; four rows were normalised)
  • Directions, gait, action meanings and look directions visually correct
  • Transparent edges checked on checkerboard, dark and light (0 fringed pixels of 18,052 sampled)
  • No generated previews, READMEs, pets.json or QA media included
  • No unrelated files
  • npm run validate:pr / npm run lint pass — see note above

Original grimdark chibi sci-fi cadet in black-and-brass armor.
88 poses, atlas 1536x2288 (8x11, frames 192x208), spriteVersionNumber 2,
WebP lossless, CC BY-NC 4.0.

Also adds the install-manifest record required by scripts/validate-pets.mjs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • pets/chud-codex--jorge-cuevas90003/spritesheet.webp
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fdb115c-3e9d-4de1-9673-bb5ab3cd6120

📥 Commits

Reviewing files that changed from the base of the PR and between 82ccbdd and 98e5d82.

📒 Files selected for processing (1)
  • pets/chud-codex--jorge-cuevas90003/spritesheet.webp

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

新增 Chud Codex 宠物包。变更包括宠物配置、提交元数据和安装清单注册信息。清单记录精灵版本、校验和、文件大小及尺寸。

Changes

Chud Codex 宠物

Layer / File(s) Summary
宠物元数据与清单注册
pets/chud-codex--jorge-cuevas90003/pet.json, pets/chud-codex--jorge-cuevas90003/submission.json, install-manifest.json
新增 Chud Codex 的身份、描述、标签、来源、许可、资源路径和精灵校验信息,并将该宠物加入安装清单。

Estimated code review effort: 1 (简单) | ~5 minutes

Possibly related PRs

Poem

小兔打开 Codex 门,
新宠配置已登记。
精灵校验和相随,
清单尺寸写分明。
Chud Codex 跳入仓中!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题明确概括了主要变更,即新增 Chud Codex 宠物,并指出其为原创角色和 v2 版本。
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Rows 3 and 4 are swapped relative to the documented v2 order: row 3 holds
jumping and row 4 holds waving. The desktop app hardcodes hover to the
`jumping` animation, so this makes the pet wave on hover instead of jump.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@legeling

Copy link
Copy Markdown
Owner

Thanks for the submission. The character design is strong, but the current atlas cannot be merged yet because it does not satisfy the fixed Codex v2 runtime contract.

Blocking issues found with the strict v2 atlas validator:

  1. Restore the standard row order. Row 3 must be waving and row 4 must be jumping. The current atlas deliberately swaps them, so runtime actions no longer match the documented/app contract.
  2. Clear every unused cell to full transparency. The following unused cells currently contain complete character frames:
    • row 0: column 7
    • row 3: columns 4-7
    • row 4: columns 5-7
    • row 6: columns 6-7
    • row 7: columns 6-7
    • row 8: columns 6-7
  3. Remove transparent RGB residue. The atlas contains 30,338 fully transparent pixels with non-zero RGB values.
  4. Remove install-manifest.json from this PR. Pet submissions should contain only the three files under pets/chud-codex--jorge-cuevas90003/; repository manifests are generated automatically after merge.

The strict validator currently reports 15 errors. After rebuilding the atlas, please verify it is 1536x2288, preserves the standard 8x11 row contract, leaves all unused slots transparent, and has zero transparent RGB residue. Once these items are corrected, we can rerun the repository checks and review it again.

- Restore the documented row order: row 3 waving, row 4 jumping.
- Clear every cell the runtime never plays (idle 7, waving 4, jumping 5,
  waiting/running/review 6) to full transparency.
- Zero the RGB channel on fully transparent pixels (30,338 -> 0).
- Drop the install-manifest.json change; it is generated after merge.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@legeling legeling left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the updated atlas. The standard v2 row order and unused-cell layout are corrected, transparent RGB residue is zero, strict v2 validation passes with no errors or warnings, and the repository PR validation, formatting, preview generation, and web build all pass.

@legeling
legeling merged commit 4554846 into legeling:main Aug 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants